[Brave News]: Add sync support#37144
Open
fallaciousreasoning wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Note for reviewers: This is my first syncable pref, so if something looks wrong it probably is. |
Contributor
📋 Code Owners Summary4 file(s) changed, 1 with assigned owners 1 team(s) affected: Owners and Their Files
|
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
netzenbot
reviewed
Jun 10, 2026
| @@ -1,5 +1,6 @@ | |||
| include_rules = [ | |||
| "+components/prefs", | |||
| "+components/pref_registry", | |||
Collaborator
There was a problem hiding this comment.
nit: pref_registry_syncable.h is only included in pref_names.cc, so this allowlist entry belongs in specific_include_rules keyed to pref_names\.cc rather than the broad include_rules. See BS-030.
Collaborator
|
HUGEEEEEE |
| {"brave.today.userfeeds", | ||
| {brave_syncable_prefs_ids::kBraveNewsDirectFeeds, syncer::PREFERENCES, | ||
| sync_preferences::PrefSensitivity::kNone, | ||
| sync_preferences::MergeBehavior::kNone}}, |
Contributor
Author
There was a problem hiding this comment.
I'm a bit worried about this on initial sync
Contributor
|
Chromium major version is behind target branch (149.0.7827.59 vs 150.0.7871.13). Please rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#23054
Closes #37013
Closes brave/go-sync#429
I had a play around with more complicated sync strategies here but merging gets a lot more complicated unless we add timestamps to individual entires. I think for the most part this should be a pretty massive improvement.
One case where this won't work properly is if you make edits on two different devices, the first edit will win.