Skip to content

set_regex_discard_policy doesn't need mut#704

Open
antonok-edm wants to merge 1 commit into
masterfrom
set_regex_discard_policy-non-mut
Open

set_regex_discard_policy doesn't need mut#704
antonok-edm wants to merge 1 commit into
masterfrom
set_regex_discard_policy-non-mut

Conversation

@antonok-edm

Copy link
Copy Markdown
Collaborator

it should be safe:

  • single-thread enabled: no concurrency
  • single-thread disabled: Mutex guarded

@antonok-edm antonok-edm self-assigned this Jul 17, 2026
@antonok-edm
antonok-edm requested review from atuchin-m and boocmp July 17, 2026 00:31

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Details
Benchmark suite Current: e47311b Previous: 407c3e4 Ratio
rule-match-browserlike/brave-list 2248269745 ns/iter (± 25790990) 2412309277 ns/iter (± 20472813) 0.93
rule-match-first-request/brave-list 1383384 ns/iter (± 11397) 1487840 ns/iter (± 18276) 0.93
blocker_new/brave-list 113175264 ns/iter (± 686551) 115035897 ns/iter (± 540336) 0.98
blocker_new/brave-list-deserialize 27872134 ns/iter (± 1498669) 39312725 ns/iter (± 1282662) 0.71
memory-usage-final/brave-list-initial 9560762 B/iter (± 0) 9560762 B/iter (± 0) 1
memory-usage-final/brave-list-1000-requests 3157476 B/iter (± 0) 3157476 B/iter (± 0) 1
memory-usage-max/brave-list-initial/max 32069450 B/iter (± 0) 32069450 B/iter (± 0) 1
memory-usage-alloc-count/brave-list-initial/alloc-count 282954 allocs/iter (± 0) 282954 allocs/iter (± 0) 1
memory-usage-alloc-count/brave-list-1000-requests/alloc-count 80015 allocs/iter (± 0) 80015 allocs/iter (± 0) 1
url_cosmetic_resources/brave-list 184187 ns/iter (± 779) 193923 ns/iter (± 905) 0.95
cosmetic-class-id-match/brave-list 3452914 ns/iter (± 920076) 3344010 ns/iter (± 856464) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants