set_regex_discard_policy doesn't need mut#704
Open
antonok-edm wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Rust Benchmark
Details
| Benchmark suite | Current: e47311b | Previous: 407c3e4 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2248269745 ns/iter (± 25790990) |
2412309277 ns/iter (± 20472813) |
0.93 |
rule-match-first-request/brave-list |
1383384 ns/iter (± 11397) |
1487840 ns/iter (± 18276) |
0.93 |
blocker_new/brave-list |
113175264 ns/iter (± 686551) |
115035897 ns/iter (± 540336) |
0.98 |
blocker_new/brave-list-deserialize |
27872134 ns/iter (± 1498669) |
39312725 ns/iter (± 1282662) |
0.71 |
memory-usage-final/brave-list-initial |
9560762 B/iter (± 0) |
9560762 B/iter (± 0) |
1 |
memory-usage-final/brave-list-1000-requests |
3157476 B/iter (± 0) |
3157476 B/iter (± 0) |
1 |
memory-usage-max/brave-list-initial/max |
32069450 B/iter (± 0) |
32069450 B/iter (± 0) |
1 |
memory-usage-alloc-count/brave-list-initial/alloc-count |
282954 allocs/iter (± 0) |
282954 allocs/iter (± 0) |
1 |
memory-usage-alloc-count/brave-list-1000-requests/alloc-count |
80015 allocs/iter (± 0) |
80015 allocs/iter (± 0) |
1 |
url_cosmetic_resources/brave-list |
184187 ns/iter (± 779) |
193923 ns/iter (± 905) |
0.95 |
cosmetic-class-id-match/brave-list |
3452914 ns/iter (± 920076) |
3344010 ns/iter (± 856464) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
boocmp
approved these changes
Jul 17, 2026
atuchin-m
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it should be safe:
single-threadenabled: no concurrencysingle-threaddisabled:Mutexguarded