to option#700
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| NetworkFilter::VT_OPT_TO_DOMAINS, | ||
| None, | ||
| ) | ||
| } |
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] Detected 'unsafe' usage, please audit for secure usage
Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage
Cc @thypon
Please consider an alternative approach that avoids this security concern, or request a review from the sec-team on slack.
| NetworkFilter::VT_OPT_NOT_TO_DOMAINS, | ||
| None, | ||
| ) | ||
| } |
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] Detected 'unsafe' usage, please audit for secure usage
Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage
Cc @thypon
Please consider an alternative approach that avoids this security concern, or request a review from the sec-team on slack.
There was a problem hiding this comment.
Rust Benchmark
Details
| Benchmark suite | Current: ffa3cd0 | Previous: 18448c9 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
3070132908 ns/iter (± 41547436) |
2447844232 ns/iter (± 28535481) |
1.25 |
rule-match-first-request/brave-list |
2828540 ns/iter (± 17452) |
1424614 ns/iter (± 42334) |
1.99 |
blocker_new/brave-list |
117297292 ns/iter (± 729115) |
115700795 ns/iter (± 3582820) |
1.01 |
blocker_new/brave-list-deserialize |
35855947 ns/iter (± 1228721) |
31365728 ns/iter (± 997370) |
1.14 |
memory-usage-final/brave-list-initial |
9599690 B/iter (± 0) |
9560762 B/iter (± 0) |
1.00 |
memory-usage-final/brave-list-1000-requests |
4519908 B/iter (± 0) |
3157476 B/iter (± 0) |
1.43 |
memory-usage-max/brave-list-initial/max |
32108634 B/iter (± 0) |
32069450 B/iter (± 0) |
1.00 |
memory-usage-alloc-count/brave-list-initial/alloc-count |
284537 allocs/iter (± 0) |
282954 allocs/iter (± 0) |
1.01 |
memory-usage-alloc-count/brave-list-1000-requests/alloc-count |
112568 allocs/iter (± 0) |
80015 allocs/iter (± 0) |
1.41 |
url_cosmetic_resources/brave-list |
185698 ns/iter (± 761) |
194256 ns/iter (± 11571) |
0.96 |
cosmetic-class-id-match/brave-list |
3458722 ns/iter (± 846221) |
3147531 ns/iter (± 850732) |
1.10 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: ffa3cd0 | Previous: 18448c9 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
3070132908 ns/iter (± 41547436) |
2447844232 ns/iter (± 28535481) |
1.25 |
rule-match-first-request/brave-list |
2828540 ns/iter (± 17452) |
1424614 ns/iter (± 42334) |
1.99 |
blocker_new/brave-list-deserialize |
35855947 ns/iter (± 1228721) |
31365728 ns/iter (± 997370) |
1.14 |
memory-usage-final/brave-list-1000-requests |
4519908 B/iter (± 0) |
3157476 B/iter (± 0) |
1.43 |
memory-usage-alloc-count/brave-list-1000-requests/alloc-count |
112568 allocs/iter (± 0) |
80015 allocs/iter (± 0) |
1.41 |
This comment was automatically generated by workflow using github-action-benchmark.
a977efd to
a5dca2a
Compare
6c981bf to
123e4bd
Compare
1 participant
No description provided.