Handle malformed content-blocking domain metadata#662
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
unwrap()while rebuildingdomain=options fromraw_line.NetworkFilterhas domain metadata but an inconsistent or malformed debugraw_line, conversion can unwind even thoughTryFrom<NetworkFilter>already returnsResult.Root cause
opt_domains/opt_not_domainsalways implied a$domain=option inraw_line.Solution
FromNotSupportederror when domain metadata cannot be reconstructed fromraw_line.RuleContainsNonASCIIerror when IDNA normalization fails.Tests run
cargo fmt --all -- --checkcargo check -p adblockcargo check -p adblock --features content-blockingcargo test -p adblock --features content-blocking domain_metadata_without_parseable_options_is_unsupported -- --nocapturecargo test -p adblock --features content-blocking content_blocking -- --nocapturecargo test -p adblock --lib --features content-blockingcargo test -p adblock --libcargo clippy -p adblock --features content-blocking -- -D warningsgit diff --checkRelated: #432