Skip to content

test: compare Google OAuth scopes exactly - #52

Merged
DorianZheng merged 1 commit into
mainfrom
google-scope-assertion
Sep 23, 2026
Merged

DorianZheng merged 1 commit into
mainfrom
google-scope-assertion

Conversation

@DorianZheng

Copy link
Copy Markdown
Member

CodeQL misidentified an OAuth scope array lookup as URL substring validation in #51. Compare the full scope set instead, so the test rejects both missing and additional permissions without the ambiguous lookup.

Validation: the unchanged production tree with this assertion reports 225 tests passed and one live test skipped. No runtime behavior changes.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 194019cb-89a9-474d-b128-38e26fcd730e

📥 Commits

Reviewing files that changed from the base of the PR and between 874c065 and bcb9307.

📒 Files selected for processing (1)
  • test/google-tools.test.mjs
 _________________________________________
< Making HAL 9000 open the pod bay doors. >
 -----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@DorianZheng
DorianZheng marked this pull request as ready for review September 23, 2026 08:45
Copilot AI lite review requested due to automatic review settings September 23, 2026 08:45

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, comment @claude review on this pull request, or push a new commit, to trigger a review.

@DorianZheng
DorianZheng merged commit 42aa1c0 into main Sep 23, 2026
4 of 5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@DorianZheng
DorianZheng deleted the google-scope-assertion branch September 23, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants