mask proxy credentials by rebuilding netloc, not substring replace - #3752
Open
ubeddulla wants to merge 1 commit into
Open
mask proxy credentials by rebuilding netloc, not substring replace#3752ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mask_proxy_url masks the userinfo with proxy_url.replace(username, mask, 1) and the same for the password, but str.replace swaps the first occurrence of that substring anywhere in the url, so when the credential value also appears earlier (in the scheme or host) the mask lands there and the real secret survives in the string that gets logged through ProxyConnectionError. for instance https://user:https@proxy.example.com masks to https://***:https@proxy.example.com with the password still visible. rebuilding the netloc from the parsed userinfo and host masks only the actual credential fields.