Skip to content

feat(credentials): allow docker host metadata URI #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohan-patnaik wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(credentials): allow docker host metadata URI #3712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions botocore/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3075,6 +3075,7 @@ class ContainerMetadataFetcher:
'169.254.170.23',
'fd00:ec2::23',
'localhost',
'host.docker.internal',
]

def __init__(self, session=None, sleep=time.sleep):
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2775,6 +2775,11 @@ def test_localhost_http_is_allowed(self):
def test_localhost_with_port_http_is_allowed(self):
self.assert_can_retrieve_metadata_from('http://localhost:8000/foo')

def test_docker_host_http_is_allowed(self):
self.assert_can_retrieve_metadata_from(
'http://host.docker.internal/foo'
)

def test_localhost_https_is_allowed(self):
self.assert_can_retrieve_metadata_from('https://localhost/foo')

Expand Down