Skip to content

Remove Windows native module - #79

Merged
ofalvai merged 1 commit into
masterfrom
push-oququsuvqzkp
Oct 5, 2026
Merged

ofalvai merged 1 commit into
masterfrom
push-oququsuvqzkp

Conversation

@ofalvai

@ofalvai ofalvai commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

We have no plans to maintain this platform

Copilot AI balanced review requested due to automatic review settings October 5, 2026 13:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Contributor guidance still points to the retired CodePushDemoAppCpp Windows example.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Removes maintained and legacy Windows native modules, leaving iOS and Android as supported platforms.

Changes:

  • Deletes Windows C++ and legacy C# implementations, build files, dependencies, and tests.
  • Removes Windows setup documentation and support references.
  • Cleans obsolete Windows ignore rules.
File Description
windows/​Directory.Build.props Removes Windows build properties.
windows/​CodePush/​ReactPackageProvider.idl Removes package-provider interface.
windows/​CodePush/​ReactPackageProvider.h Removes package-provider declaration.
windows/​CodePush/​ReactPackageProvider.cpp Removes package-provider implementation.
windows/​CodePush/​PropertySheet.props Removes C++ property sheet.
windows/​CodePush/​pch.h Removes precompiled header.
windows/​CodePush/​pch.cpp Removes precompiled-header source.
windows/​CodePush/​packages.config Removes Windows NuGet configuration.
windows/​CodePush/​miniz/​readme.md Removes bundled miniz documentation.
windows/​CodePush/​miniz/​LICENSE Removes bundled miniz license.
windows/​CodePush/​FileUtils.h Removes Windows file utility API.
windows/​CodePush/​FileUtils.cpp Removes Windows file utilities.
windows/​CodePush/​CodePushUtils.h Removes Windows utility API.
windows/​CodePush/​CodePushUtils.cpp Removes Windows utilities.
windows/​CodePush/​CodePushUpdateUtils.h Removes update utility API.
windows/​CodePush/​CodePushUpdateUtils.cpp Removes update utilities.
windows/​CodePush/​CodePushTelemetryManager.h Removes telemetry API.
windows/​CodePush/​CodePushTelemetryManager.cpp Removes telemetry implementation.
windows/​CodePush/​CodePushPackage.h Removes package-management API.
windows/​CodePush/​CodePushPackage.cpp Removes package management.
windows/​CodePush/​CodePushNativeModule.h Removes native module API.
windows/​CodePush/​CodePushNativeModule.cpp Removes native module implementation.
windows/​CodePush/​CodePushDownloadHandler.h Removes download handler API.
windows/​CodePush/​CodePushDownloadHandler.cpp Removes download handling.
windows/​CodePush/​CodePushConfig.idl Removes configuration interface.
windows/​CodePush/​CodePushConfig.h Removes configuration declaration.
windows/​CodePush/​CodePushConfig.cpp Removes configuration implementation.
windows/​CodePush/​CodePush.vcxproj.filters Removes Visual Studio filters.
windows/​CodePush/​CodePush.vcxproj Removes Windows C++ project.
windows/​CodePush/​CodePush.def Removes DLL exports.
windows/​CodePush/​.npmignore Removes module-specific package ignores.
windows/​.npmignore Removes Windows package ignores.
windows/​.gitignore Removes Windows source ignores.
windows-legacy/​CodePush/​UpdateUtils.cs Removes legacy UWP update utilities.
windows-legacy/​CodePush/​UpdateManager.cs Removes legacy UWP update manager.
windows-legacy/​CodePush/​Properties/​CodePush.rd.xml Removes runtime directives.
windows-legacy/​CodePush/​Properties/​AssemblyInfo.cs Removes UWP assembly metadata.
windows-legacy/​CodePush/​FileUtils.cs Removes legacy file utilities.
windows-legacy/​CodePush/​CodePushUtils.cs Removes legacy CodePush utilities.
windows-legacy/​CodePush/​CodePush.csproj Removes legacy UWP project.
windows-legacy/​CodePush/​.gitignore Removes UWP project ignores.
windows-legacy/​CodePush.Shared/​UpdateState.cs Removes update-state enum.
windows-legacy/​CodePush.Shared/​TelemetryManager.cs Removes shared telemetry manager.
windows-legacy/​CodePush.Shared/​SettingsManager.cs Removes shared settings manager.
windows-legacy/​CodePush.Shared/​MinimumBackgroundListener.cs Removes lifecycle listener.
windows-legacy/​CodePush.Shared/​InstallMode.cs Removes install-mode enum.
windows-legacy/​CodePush.Shared/​CodePushUtils.cs Removes shared utilities.
windows-legacy/​CodePush.Shared/​CodePushReactPackage.cs Removes legacy React package.
windows-legacy/​CodePush.Shared/​CodePushNativeModule.cs Removes legacy native module.
windows-legacy/​CodePush.Shared/​CodePushConstants.cs Removes Windows constants.
windows-legacy/​CodePush.Shared/​CodePush.Shared.shproj Removes shared project.
windows-legacy/​CodePush.Shared/​CodePush.Shared.projitems Removes shared project items.
windows-legacy/​CodePush.Net46/​UpdateUtils.cs Removes .NET update utilities.
windows-legacy/​CodePush.Net46/​UpdateManager.cs Removes .NET update manager.
windows-legacy/​CodePush.Net46/​Properties/​AssemblyInfo.cs Removes .NET assembly metadata.
windows-legacy/​CodePush.Net46/​packages.config Removes .NET package configuration.
windows-legacy/​CodePush.Net46/​FileUtils.cs Removes .NET file utilities.
windows-legacy/​CodePush.Net46/​CodePushUtils.cs Removes .NET CodePush utilities.
windows-legacy/​CodePush.Net46/​CodePush.Net46.csproj Removes .NET Framework project.
windows-legacy/​CodePush.Net46/​Adapters/​Storage/​ApplicationDataContainer.cs Removes storage adapter.
windows-legacy/​CodePush.Net46/​Adapters/​Http/​HttpProgress.cs Removes HTTP progress adapter.
windows-legacy/​CodePush.Net46/​.gitignore Removes .NET project ignores.
windows-legacy/​CodePush.Net46.Test/​TelemetryManagerTest.cs Removes telemetry tests.
windows-legacy/​CodePush.Net46.Test/​Properties/​AssemblyInfo.cs Removes test assembly metadata.
windows-legacy/​CodePush.Net46.Test/​packages.config Removes test package configuration.
windows-legacy/​CodePush.Net46.Test/​CodePush.Net46.Test.csproj Removes Windows test project.
windows-legacy/​CodePush.Net46.Test/​ApplicationDataContainerTest.cs Removes storage tests.
windows-legacy/​CodePush.Net46.Test/​app.config Removes test runtime configuration.
windows-legacy/​.npmignore Removes legacy package ignores.
windows-legacy/​.gitignore Removes legacy source ignores.
README.md Removes Windows support and setup links.
docs/​setup-windows.md Removes Windows setup guide.
AGENTS.md Updates architecture documentation.
.npmignore Removes obsolete Windows exclusions.
.gitignore Removes obsolete Windows exclusions.
.github/​ISSUE_TEMPLATE.md Removes Windows from issue metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md
Comment on lines 34 to 35
- [iOS Setup](docs/setup-ios.md)
- [Android Setup](docs/setup-android.md)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's another probably-dead piece of code, it's on my list to delete completely, just want to investigate its purpose a bit better.

@ofalvai
ofalvai merged commit cb6bcce into master Oct 5, 2026
7 checks passed
@ofalvai
ofalvai deleted the push-oququsuvqzkp branch October 5, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants