Repository navigation
Log the SDK configuration at JS initialization - #75
Merged
Merged
Conversation
ofalvai
added this pull request to stack #74
September 30, 2026 08:33
ofalvai
force-pushed
the
push-xvqkwzuvuwvt
branch
from
September 30, 2026 11:33
c61e25f to
5d9f620
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new log exposes a persistent client identifier.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Caches configuration retrieval per JS runtime and adds one-time diagnostic logging.
Changes:
- Caches concurrent configuration requests and retries after failure.
- Logs SDK, app, binary, and active-package details.
| File | Description |
|---|---|
CodePush.js |
Adds configuration caching and runtime diagnostics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ofalvai
marked this pull request as ready for review
September 30, 2026 11:39
ofalvai
force-pushed
the
push-xvqkwzuvuwvt
branch
from
September 30, 2026 13:09
5d9f620 to
0a1aadd
Compare
ofalvai
force-pushed
the
push-xvqkwzuvuwvt
branch
from
October 1, 2026 07:29
0a1aadd to
3d8245f
Compare
miklosboros
approved these changes
Oct 1, 2026
ofalvai
force-pushed
the
push-xvqkwzuvuwvt
branch
from
October 1, 2026 12:24
3d8245f to
d4fd913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Logs from a device with a failing OTA update often lack the basics. They do not say which SDK version ran, which binary version ran, or whether the app ran the binary bundle or a CodePush update. This PR adds one
infoline with those facts. The SDK writes it the first time the JS layer reads the native configuration.Example output:
Decisions
getConfiguration. The log call is fire-and-forget and swallows its errors.getConfigurationreturns as soon as native answers. If the running-package lookup fails, the line still appears and reportsfromBinary.syncstarts the status report and the update check at nearly the same time. With a cached value, both calls miss the cache and fetch the configuration. They would also log it twice. With a cached promise, the second call reuses the first. A rejected promise clears the cache, so a failed call can retry. This matches the old behavior._isDebugOnly. Reporting it asfromCodePushwould be wrong, so the log treats it asfromBinary.