[jtx rewrite] Add Handlers for Recurrence Fields#2267
Closed
ArnyminerZ wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds recurrence-field support to the new JTX mapping pipeline by introducing a dedicated RecurrenceFieldsHandler, wiring it into JtxObjectHandler, and covering the behavior with unit tests (including a regression case for “RDATE-only recurrence”).
Changes:
- Implement
RecurrenceFieldsHandlerto mapRRULE,RDATE,EXDATE, and exceptionRECURRENCE-ID. - Update
JtxObjectHandlerto treatRDATEas recurrence so exceptions are included even without anRRULE. - Add/extend Robolectric tests for both the new handler and exception-inclusion behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| synctools/src/main/kotlin/at/bitfire/synctools/mapping/jtx/JtxObjectHandler.kt | Registers the new handler and includes exceptions for RRULE or RDATE recurrence. |
| synctools/src/main/kotlin/at/bitfire/synctools/mapping/jtx/handler/RecurrenceFieldsHandler.kt | New handler mapping recurrence-related fields from JTX entities to ical4j properties. |
| synctools/src/test/kotlin/at/bitfire/synctools/mapping/jtx/JtxObjectHandlerTest.kt | Adds regression tests ensuring exceptions are included for RDATE-only recurrence. |
| synctools/src/test/kotlin/at/bitfire/synctools/mapping/jtx/handler/RecurrenceFieldsHandlerTest.kt | New test suite validating recurrence field mapping across timezone/all-day/floating cases. |
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Copied from bitfireAT/synctools#410
Short description
RecurrenceFieldsHandlerChecklist