Repository navigation
(improvements) Wallets report - #1133
Merged
Merged
Conversation
alexstotsky
marked this pull request as ready for review
October 20, 2026 11:25
jeojoe
approved these changes
Oct 20, 2026
bhoomij
approved these changes
Oct 20, 2026
alexstotsky
added a commit
to alexstotsky/bfx-report-ui
that referenced
this pull request
Oct 23, 2026
jeojoe
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana tasks:
https://app.asana.com/1/29923630752984/home/task/1219294678724742
https://app.asana.com/1/29923630752984/home/task/1219488779726538
Description:
Walletsreport performance using the newgetWalletsendpoint flag to convert to USD by public trades instead of the overloadedgetFullSnapshotReportendpoint, in the following way:Balance (USD)option:getWalletsforApproximateandgetWalletswith theisCcyConvertedUsingPublicTradesflag forExactgetFullSnapshotReportrequest on theWalletspage open, date and precision change, and after sync, so it no longer overwrites theSnapshotsreport dataWalletsto functional component as part of our global class-to-functional refactoringPreview:
wallets-flow-prev.mov
Target Release:
v2.66.0
Related Pull Requests:
Type:
Notes: