Skip to content

(improvements) Wallets report - #1133

Merged
jeojoe merged 8 commits into
bitfinexcom:stagingfrom
alexstotsky:improve-wallets
Oct 23, 2026
Merged

jeojoe merged 8 commits into
bitfinexcom:stagingfrom
alexstotsky:improve-wallets

Conversation

@alexstotsky

@alexstotsky alexstotsky commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Asana tasks:

https://app.asana.com/1/29923630752984/home/task/1219294678724742
https://app.asana.com/1/29923630752984/home/task/1219488779726538

Description:

  • Improves the Wallets report performance using the new getWallets endpoint flag to convert to USD by public trades instead of the overloaded getFullSnapshotReport endpoint, in the following way:
  • Sends only one request according to the selected Balance (USD) option: getWallets for Approximate and getWallets with the isCcyConvertedUsingPublicTrades flag for Exact
  • Stops firing the heavy getFullSnapshotReport request on the Wallets page open, date and precision change, and after sync, so it no longer overwrites the Snapshots report data
  • Refactors Wallets to functional component as part of our global class-to-functional refactoring

Preview:

wallets-flow-prev.mov

Target Release:

v2.66.0


Related Pull Requests:

Type:

  • fix
  • refactor
  • feature
  • improvement
  • internal
  • chore
  • other (specify)

Notes:

  • includes package-lock.json change
  • includes breaking changes
  • includes new TODO/HACK lines
  • other (specify)

@alexstotsky
alexstotsky marked this pull request as ready for review October 20, 2026 11:25
alexstotsky added a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 23, 2026
@jeojoe
jeojoe merged commit 695bfb3 into bitfinexcom:staging Oct 23, 2026
2 checks passed
@alexstotsky
alexstotsky deleted the improve-wallets branch October 23, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants