Remove BIP 110 following unsuccessful activation attempt - #2247
Closed
callebtc wants to merge 1 commit into
Closed
Conversation
Contributor
|
NACK I think it's important for failed BIPs to be preserved for educational purposes. Those who do not learn from history are doomed to repeat it. |
Member
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove BIP 110, its test vectors, and its entry from the BIP index following the unsuccessful attempt to activate it on Bitcoin.
Rationale
BIP 110 required mandatory version-bit signaling beginning at block height 961632. Blocks 961632 through 963647 that did not signal bit 4 were invalid under the proposal.
At height 961632, Bitcoin's accumulated-work chain accepted block:
00000000000000000000d1e01392faa65ceeaed307f0a3159144b84146ff24ba0x20006000BIP-110-enforcing nodes rejected that block and followed an alternative signaling block mined by OCEAN:
0000000000000000000169eb6f811ddbd0daf343af7b62180cdb13e7c78dbc160x27d60010Scope
This removes:
bip-0110.mediawikibip-0110/test-vectors.jsonbip-0110/test-vectors.pyREADME.mediawikiReferences