qt: filter addhdkey from RPC console history - #955
Open
mateusz-klatt wants to merge 1 commit into
Open
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process. |
The addhdkey RPC accepts a BIP 32 extended private key, but it was not added to the RPC console sensitive-command filter when introduced. As a result, the key remains visible in console history. Add addhdkey to the filter and cover it in rpcnestedtests.
mateusz-klatt
force-pushed
the
qt-addhdkey-history-filter
branch
from
August 1, 2026 07:57
8cd4451 to
31467d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters
addhdkeyarguments from RPC console history, consistent with other RPCs that handle private key material.This prevents extended private keys from being retained in history. It also covers the mnemonic and passphrase inputs proposed in bitcoin/bitcoin#35857.
Adds a parser test verifying that the arguments are redacted.
Motivation
addhdkeyaccepts a BIP 32 extended private key, but its arguments are currently retained in RPC console history, unlike other RPCs that handle private key material.The same filter would also protect the mnemonic and passphrase inputs proposed in bitcoin/bitcoin#35857.
Changes
addhdkeyto the RPC console sensitive-command filter.addhdkey(…).Tests
./build_gui/bin/test_bitcoin-qt— all tests passed, includingRPCNestedTests::rpcNestedTests().