Adds option to not load the wallet after migration - #953
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
45f6171 to
e40c1e3
Compare
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
|
Concept ACK In terms of UX, I think it would be better to have this be a checkbox option in the initial dialog rather than a second dialog that the user has to click through. |
e40c1e3 to
2b4f57c
Compare
Done, modified the description to show the current UI. |
|
Concept ACK |
2b4f57c to
4cea595
Compare
|
ACK 4cea595 |
…migration 3bfd600 add release notes (Pol Espinasa) e0f5830 gui: Adds option to not load the wallet after migration (Pol Espinasa) Pull request description: Following bitcoin/bitcoin#35266 this PR adds the option to not load the wallet after migrating to the GUI. It is only added for the `migrate` option, not for the `restore_and_migrate`. I guess if we are restoring the wallet we always want to load it. In any case, it's pretty straightforward to implement it there too. Inside the original migration pop-up box it appears a checkbox that allows the user to choose if want to load the wallet or not, it is checked by default: <img width="497" height="388" alt="imagen" src="https://github.com/user-attachments/assets/79c76f9b-9b06-4fcb-88fe-3b5db3eaf14f" /> If yes, the wallet is loaded and shown, if not the wallet gets migrated and the GUI returns to it's state. The checkbox has a tooltip that informs when not loading a migrated wallet can be useful: <img width="503" height="494" alt="imagen" src="https://github.com/user-attachments/assets/3a3404ff-1fd3-44ef-8f9d-db526c9f032f" /> ACKs for top commit: achow101: ACK 3bfd600 pablomartin4btc: ACK 3bfd600 hebasto: ACK 3bfd600, I have reviewed the code and it looks OK. Tree-SHA512: 6256849ecca3888fe24866ed539b262be6275c6192d29d272e7ad1475943c2947c04a3fadaae94e1843b3fcfa43a1f84edb02365933bf954b8ba7d0ae53eda32
Following bitcoin/bitcoin#35266 this PR adds the option to not load the wallet after migrating to the GUI.
It is only added for the
migrateoption, not for therestore_and_migrate. I guess if we are restoring the wallet we always want to load it.In any case, it's pretty straightforward to implement it there too.
Inside the original migration pop-up box it appears a checkbox that allows the user to choose if want to load the wallet or not, it is checked by default:
If yes, the wallet is loaded and shown, if not the wallet gets migrated and the GUI returns to it's state.
The checkbox has a tooltip that informs when not loading a migrated wallet can be useful:
