Repository navigation
Conversation
- Add `TR: https://cebs.niehs.nih.gov/cebs/publication/` to prefixes. ROBOKOP's CEBS edges cite National Toxicology Program Technical Reports as `TR:TR-128`, `TR:TR-576`, ...; CEBS serves each report at that URL with the `TR-` id as written, so the CURIEs expand to working pages. Neither Biolink nor Bioregistry had a prefix for these. - Add `TR` to `publication`'s `id_prefixes`, since these ids name publications (the reports).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRtoprefixes, ashttps://cebs.niehs.nih.gov/cebs/publication/.infores:cebs) cite National Toxicology Program Technical Reports inpublicationsasTR:TR-128,TR:TR-576, and so on.TR-id exactly as written. For example,TR:TR-128expands to https://cebs.niehs.nih.gov/cebs/publication/TR-128, the "Bioassay of 3,3'-Dimethoxybenzidine-4,4'-diisocyanate for Possible Carcinogenicity" (NTP's own page: https://ntp.niehs.nih.gov/publications/reports/tr/tr128).TRtopublication'sid_prefixes. The ids name publications (the reports), alongsidePMID,PMC,doiandNLMID.On the name:
TRis short and generic, but it's what the data already uses. A longer prefix (e.g.NTP.TR) would mean rewriting the ids downstream; happy to change it if that's preferred. The prefix should also be registered with Bioregistry.Checked locally:
yamllint,make lint(no problems) andmake test-python(25 passed).