Fix upgrade-check false positive for hx-history-elt#3889
Merged
1cg merged 1 commit intoJul 13, 2026
Conversation
hx-history-elt was restored in v4 core (commit 2b39a89, bigskysoftware#3773), so the upgrade-check tool was incorrectly flagging it as removed.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
upgrade-checktool is incorrectly flagginghx-history-eltas a removed attribute, when it was actually restored in v4 core.Problem
The
REMOVED_ATTRSdictionary insrc/scripts/upgrade-check.pycontained:This caused the upgrade-check tool to warn users that
hx-history-eltshould be removed from their HTML, even though it's a valid, working attribute in htmx v4.Evidence
hx-history-eltwas restored to v4 core in commit2b39a899(PR #3773):The attribute is actively used in
src/htmx.js:1636:And documented in CHANGELOG.md:
Fix
Removed
hx-history-eltfrom theREMOVED_ATTRSdictionary insrc/scripts/upgrade-check.py.Note:
dist/scripts/upgrade-check.pyis a build copy and isn't updated here, per guidelines; should be regenerated on release.Testing
The upgrade-check tool will no longer flag
hx-history-eltas removed, allowing users to keep this valid attribute in their HTML.Checklist
masterfor website changes,devfor source changes)npm run test) and verified that it succeeded