cache compiled eval tags in safeEval feature for better hx-live perf#3888
Open
MichaelWest22 wants to merge 1 commit into
Open
cache compiled eval tags in safeEval feature for better hx-live perf#3888MichaelWest22 wants to merge 1 commit into
MichaelWest22 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Found that hx-csp creates temporary script tags via its safeEval feature but when using things like hx-live this means it re-creates the same eval script each dom update. We can easily cache the functions and reuse them so they do not need to be be re-created every time.
Corresponding issue:
Testing
Tested this manually in a test project to confirm faster performance during events. It went from ~2ms to fire a small batch of expressions down to ~1.2ms. before safe-eval was a bit slower by design than normal eval but now it is just a little bit faster but the perf difference is hard to notice comparing the two.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded