fix(consensus): reject gossiped commits with more than MaxVotesCount … - #54
Open
fridrik01 wants to merge 1 commit into
Open
fix(consensus): reject gossiped commits with more than MaxVotesCount …#54fridrik01 wants to merge 1 commit into
fridrik01 wants to merge 1 commit into
Conversation
fridrik01
force-pushed
the
fix-consensus-commit-sig-count-cap
branch
from
July 24, 2026 12:36
d717665 to
a7c811f
Compare
fridrik01
force-pushed
the
fix-consensus-commit-sig-count-cap
branch
from
August 6, 2026 15:27
a7c811f to
ab1bb7a
Compare
fridrik01
marked this pull request as ready for review
August 6, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR caps the number of signatures in gossiped
CommitMessageattypes.MaxVotesCount, rejecting oversized commits inValidateBasicand disconnecting the peer. This prevents a peer from sending a~1MBheight-zero commit with hundreds of thousands of absent signatures.