refactor: replace @vitejs/plugin-react-swc with @vitejs/plugin-react … - #148
Open
freds-dev wants to merge 2 commits into
Open
refactor: replace @vitejs/plugin-react-swc with @vitejs/plugin-react …#148freds-dev wants to merge 2 commits into
freds-dev wants to merge 2 commits into
Conversation
…and update Vite config paths - Updated package.json files in demo and lib packages to use @vitejs/plugin-react version 5.1.1 instead of @vitejs/plugin-react-swc version 4.3.1. - Modified vite.config.ts files in demo and lib packages to resolve paths using import.meta.dirname for better directory handling.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 93.57% 93.68% +0.11%
==========================================
Files 91 91
Lines 1665 1664 -1
Branches 262 262
==========================================
+ Hits 1558 1559 +1
+ Misses 91 90 -1
+ Partials 16 15 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
forman
approved these changes
Sep 9, 2026
b-yogesh
reviewed
Sep 9, 2026
| @@ -1,5 +1,8 @@ | |||
| ## Version 0.2.2 (in development) | |||
|
|
|||
| * Replaced `@vitejs/plugin-react-swc` with `@vitejs/plugin-react` and | |||
Collaborator
There was a problem hiding this comment.
You can mention the issue number in this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the Vite warnings shown when running the Chartlets demo UI locally.
Changes:
@vitejs/plugin-react-swcwith@vitejs/plugin-reactin the demo and library packages.import.meta.dirnameinstead of__dirname.chartlets.js/package-lock.json.chartlets.js/CHANGES.md.Motivation
Vite warns that
__dirnameis unsupported by the upcoming native config loader behavior. It also recommends switching from@vitejs/plugin-react-swcto@vitejs/plugin-reactbecause no SWC plugins are configured.These warnings appear when running:
cd chartlets.js/packages/demo npm run devVerification
Tested locally with Node
v22.13.1:cd chartlets.js/packages/demo npm run devThe dev server starts without the previous Vite/native-config and React SWC warnings.
closes #147