Skip to content

fix: unfold the sync-progress changelog entry the v0.169.2 release folded - #297

Merged
bborbe merged 1 commit into
masterfrom
fix/unfold-sync-progress-changelog
Oct 15, 2026
Merged

bborbe merged 1 commit into
masterfrom
fix/unfold-sync-progress-changelog

Conversation

@bborbe

@bborbe bborbe commented Oct 15, 2026

Copy link
Copy Markdown
Owner

The v0.169.2 release commit (0b98886) is the first parent of the merge that carried this change (a87e548). The cut therefore landed during the branch's review window, and GitHub's merge combined the branch's ## Unreleased bullet with master's rename cleanly — no conflict marker — leaving the bullet under the already-released ## v0.169.2.

Evidence that the tag does not carry the fix:

git tag --contains a87e548                                   # empty
git diff --stat v0.169.2 a87e548 -- commands/sync-progress.md # 3 ++-
git show v0.169.2:.claude-plugin/plugin.json                 # version 0.169.2
git show origin/master:.claude-plugin/plugin.json            # version 0.169.2

The release commit bumps plugin.json and marketplace.json, so the tag and master claim one version number with different contents — a consumer pinning 0.169.2 gets the pre-fix tree under the version master advertises as fixed. Master was also left with no ## Unreleased, so the releaser had nothing left to cut.

Repair

## Unreleased restored above ## v0.169.2; the folded bullet moved into it; the sibling session's create-task bullet left where it is.

Verified:

  • MINE sits under: ## Unreleased and THEIRS sits under: ## v0.169.2
  • ## v0.169.2 byte-identical to git show v0.169.2:CHANGELOG.md
  • no -- line in git diff origin/master -- CHANGELOG.md — no sibling bullet dropped
  • make precommit PASS

The release trigger is held until this merges: triggering a cut while the repair sits in review would rename ## Unreleased at a master that does not yet carry the repair, folding the entry straight back in.

…lded

The v0.169.2 release commit was the first parent of the merge that carried
this change, so GitHub's merge combined the branch's ## Unreleased bullet
with master's rename cleanly and left the bullet under the already-released
## v0.169.2. git tag --contains the merge is empty and the tagged tree lacks
the fix, while master carries it at the same version number.

Restore ## Unreleased above ## v0.169.2 and move the bullet back into it.
The released section is left byte-identical to its own tag.
@bborbe
bborbe marked this pull request as ready for review October 15, 2026 17:16

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have all inputs. Let me perform Step 4c-sel CLASSIFY:

Candidates (7): changelog/conventional-prefix-required, git-commit/feature-branch-no-tag, git-commit/imperative-mood, git-workflow/never-direct-commit-to-master, go-security/resource-ownership, go-security/tenant-isolation, markdown-todo/lowercase-x-for-complete

Classification:

  • changelog/conventional-prefix-required — applies when: bullet under ## Unreleased missing prefix. The diff inserts ## Unreleased with no bullets — no bullet to check → skipped
  • markdown-todo/lowercase-x-for-complete — applies to task lists ([x]/[ ]). CHANGELOG.md uses no task-list syntax → skipped
  • git-commit/feature-branch-no-tag — commit msg rule, not file-diff rule; no @commits trigger → skipped
  • git-commit/imperative-mood — commit msg rule; no @commits trigger → skipped
  • git-workflow/never-direct-commit-to-master — git workflow rule; no @commits trigger → skipped
  • go-security/resource-ownership — Go security; no Go files changed → skipped
  • go-security/tenant-isolation — Go security; no Go files changed → skipped

Applicable set: empty — selector clean: no adjudication needed

Step 4d-sel skipped (0 applicable rules). Step 3b (precommit) skipped per selector mode.


Step 5: Consolidated Report

Must Fix (Critical)

None.

Should Fix (Important)

None.

Nice to Have (Optional)

None.


Selector mode traceability:

  • Candidates: 7 rules matched by Step 4b-i glob filter
  • Applicable: 0 rules selected by Step 4c-sel
  • Skipped:
    • changelog/conventional-prefix-required → no bullets under new ## Unreleased
    • markdown-todo/lowercase-x-for-complete → no task-list syntax in CHANGELOG.md
    • git-commit/feature-branch-no-tag → no @commits trigger
    • git-commit/imperative-mood → no @commits trigger
    • git-workflow/never-direct-commit-to-master → no @commits trigger
    • go-security/resource-ownership → no Go files changed
    • go-security/tenant-isolation → no Go files changed

Precommit: skipped (selector mode) — CI covers lint+test.

Notes:

  • This is a pure CHANGELOG.md restructuring: moving the v0.169.2 entry under a new ## Unreleased section. The ## Unreleased section is empty (no bullets added by this PR). The changelog preamble (SemVer link, MAJOR/MINOR/PATCH bullets, # Changelog title) is unchanged and intact.
  • Per changelog-guide.md § Version Alignment: ## Unreleased above a released version in an autoRelease: true repo is correct — version manifests stay at the released version until post-merge. No version bump is expected from this PR.
  • The v0.169.2 fix entry is correctly preserved and unfolded (moved from being a standalone top section to being preceded by ## Unreleased).

Concerns addressed:

  • concern: correctness of changelog structure → addressed — the unfolding is structurally correct per changelog-guide.md

{
  "verdict": "approve",
  "summary": "Pure CHANGELOG.md restructuring: adds an empty ## Unreleased section above the v0.169.2 entry, correcting a changelog fold. No code, tests, or version-string changes. No violations found.",
  "comments": [],
  "concerns_addressed": [
    {
      "concern": "correctness of changelog structure",
      "disposition": "addressed",
      "detail": "CHANGELOG.md structure verified against changelog-guide.md: preamble intact, ## Unreleased inserted correctly above v0.169.2, no conventional-prefix violations (## Unreleased has no bullets), no version strings bumped."
    }
  ]
}

@bborbe
bborbe merged commit 64bbca4 into master Oct 15, 2026
5 checks passed
@bborbe
bborbe deleted the fix/unfold-sync-progress-changelog branch October 15, 2026 17:22

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
  "verdict": "approve",
  "summary": "Single-file CHANGELOG.md edit that correctly unfolds the sync-progress changelog entry from the v0.169.2 release back into ## Unreleased, matching the PR title. The create-task entry remains in v0.169.2. No code, tests, or build artifacts touched. No issues found.",
  "comments": [],
  "concerns_addressed": []
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants