Repository navigation
fix: unfold the sync-progress changelog entry the v0.169.2 release folded - #297
Merged
Merged
Conversation
…lded The v0.169.2 release commit was the first parent of the merge that carried this change, so GitHub's merge combined the branch's ## Unreleased bullet with master's rename cleanly and left the bullet under the already-released ## v0.169.2. git tag --contains the merge is empty and the tagged tree lacks the fix, while master carries it at the same version number. Restore ## Unreleased above ## v0.169.2 and move the bullet back into it. The released section is left byte-identical to its own tag.
bborbe
marked this pull request as ready for review
October 15, 2026 17:16
There was a problem hiding this comment.
Now I have all inputs. Let me perform Step 4c-sel CLASSIFY:
Candidates (7): changelog/conventional-prefix-required, git-commit/feature-branch-no-tag, git-commit/imperative-mood, git-workflow/never-direct-commit-to-master, go-security/resource-ownership, go-security/tenant-isolation, markdown-todo/lowercase-x-for-complete
Classification:
changelog/conventional-prefix-required— applies when: bullet under## Unreleasedmissing prefix. The diff inserts## Unreleasedwith no bullets — no bullet to check → skippedmarkdown-todo/lowercase-x-for-complete— applies to task lists ([x]/[ ]). CHANGELOG.md uses no task-list syntax → skippedgit-commit/feature-branch-no-tag— commit msg rule, not file-diff rule; no@commitstrigger → skippedgit-commit/imperative-mood— commit msg rule; no@commitstrigger → skippedgit-workflow/never-direct-commit-to-master— git workflow rule; no@commitstrigger → skippedgo-security/resource-ownership— Go security; no Go files changed → skippedgo-security/tenant-isolation— Go security; no Go files changed → skipped
Applicable set: empty — selector clean: no adjudication needed
Step 4d-sel skipped (0 applicable rules). Step 3b (precommit) skipped per selector mode.
Step 5: Consolidated Report
Must Fix (Critical)
None.
Should Fix (Important)
None.
Nice to Have (Optional)
None.
Selector mode traceability:
- Candidates: 7 rules matched by Step 4b-i glob filter
- Applicable: 0 rules selected by Step 4c-sel
- Skipped:
changelog/conventional-prefix-required→ no bullets under new## Unreleasedmarkdown-todo/lowercase-x-for-complete→ no task-list syntax in CHANGELOG.mdgit-commit/feature-branch-no-tag→ no@commitstriggergit-commit/imperative-mood→ no@commitstriggergit-workflow/never-direct-commit-to-master→ no@commitstriggergo-security/resource-ownership→ no Go files changedgo-security/tenant-isolation→ no Go files changed
Precommit: skipped (selector mode) — CI covers lint+test.
Notes:
- This is a pure
CHANGELOG.mdrestructuring: moving thev0.169.2entry under a new## Unreleasedsection. The## Unreleasedsection is empty (no bullets added by this PR). The changelog preamble (SemVer link, MAJOR/MINOR/PATCH bullets,# Changelogtitle) is unchanged and intact. - Per
changelog-guide.md§ Version Alignment:## Unreleasedabove a released version in anautoRelease: truerepo is correct — version manifests stay at the released version until post-merge. No version bump is expected from this PR. - The v0.169.2 fix entry is correctly preserved and unfolded (moved from being a standalone top section to being preceded by
## Unreleased).
Concerns addressed:
concern: correctness of changelog structure→addressed— the unfolding is structurally correct per changelog-guide.md
{
"verdict": "approve",
"summary": "Pure CHANGELOG.md restructuring: adds an empty ## Unreleased section above the v0.169.2 entry, correcting a changelog fold. No code, tests, or version-string changes. No violations found.",
"comments": [],
"concerns_addressed": [
{
"concern": "correctness of changelog structure",
"disposition": "addressed",
"detail": "CHANGELOG.md structure verified against changelog-guide.md: preamble intact, ## Unreleased inserted correctly above v0.169.2, no conventional-prefix violations (## Unreleased has no bullets), no version strings bumped."
}
]
}There was a problem hiding this comment.
{
"verdict": "approve",
"summary": "Single-file CHANGELOG.md edit that correctly unfolds the sync-progress changelog entry from the v0.169.2 release back into ## Unreleased, matching the PR title. The create-task entry remains in v0.169.2. No code, tests, or build artifacts touched. No issues found.",
"comments": [],
"concerns_addressed": []
}
akujon720-dot
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v0.169.2release commit (0b98886) is the first parent of the merge that carried this change (a87e548). The cut therefore landed during the branch's review window, and GitHub's merge combined the branch's## Unreleasedbullet with master's rename cleanly — no conflict marker — leaving the bullet under the already-released## v0.169.2.Evidence that the tag does not carry the fix:
The release commit bumps
plugin.jsonandmarketplace.json, so the tag and master claim one version number with different contents — a consumer pinning0.169.2gets the pre-fix tree under the version master advertises as fixed. Master was also left with no## Unreleased, so the releaser had nothing left to cut.Repair
## Unreleasedrestored above## v0.169.2; the folded bullet moved into it; the sibling session'screate-taskbullet left where it is.Verified:
MINE sits under: ## UnreleasedandTHEIRS sits under: ## v0.169.2## v0.169.2byte-identical togit show v0.169.2:CHANGELOG.md--line ingit diff origin/master -- CHANGELOG.md— no sibling bullet droppedmake precommitPASSThe release trigger is held until this merges: triggering a cut while the repair sits in review would rename
## Unreleasedat a master that does not yet carry the repair, folding the entry straight back in.