fix: create-task asks for the vault instead of silently defaulting

CHANGELOG.md

@@ -8,6 +8,10 @@ Please choose versions by [Semantic Versioning](http://semver.org/).
 * MINOR version when you add functionality in a backwards-compatible manner, and
 * PATCH version when you make backwards-compatible bug fixes.
 
+## Unreleased
+
+- fix: `/vault-cli:create-task` and its `task-creator` agent no longer fall back silently to the configured default vault. `commands/create-task.md` documented `--vault` as optional with an implicit default, and `agents/task-creator.md` stated it outright (`Defaults: MODE = interactive, VAULT = configured default vault`) — so a task belonging to one vault was placed in another by inference, and the silent fallback is a **third** vault again, wrong for work belonging to any other. Both now resolve the vault from `--vault` or from the cwd, and **ask** when neither determines it — the convention `commands/reflect.md` (*"If cwd is not inside any vault path, ask the user which vault to write to"*) and `agents/graph-auditor.md` (*"ask user which vault to audit; do not guess"*) already carry, so this brings the pair in line with their siblings rather than adding a new rule. Observed 2026-10-15: a task belonging to `seibert-personal` was created in `seibert-brogrammers` by inference and had to be deleted and re-created, costing two `task-creator` runs (~105k tokens).
+
 ## v0.169.0
 
 - feat: a **coverage** action on `task-manager-agent` and `goal-manager-agent` — the reverse map both agents were missing. Each already checked necessity in the forward direction only (`task-manager-agent` § verify step 5: this task → the goal box it serves; `goal-manager-agent` § verify step 8: the goal's tasks → the box each serves), so nothing answered the inverse question: for each open box, what drives it, and what evidence exists for it. The action emits **one row per closure box** — `<box verbatim> | <driving item or "none"> | <evidence: measured(<source>) | asserted | none> | <proposal: create | re-scope | split | diagnosis-task | —>` — for a **goal** subject (boxes: `# Success Criteria` + `# Definition of Done`; drivers: the tasks linked in `# Tasks`) or a **topic** subject (boxes: `# Success Criteria` + `# Completion Gate`, since a topic carries no `# Definition of Done`; drivers: the member goals under `# Goals`), resolved goal-first and reported by kind. ⚠️ **`measured` requires a named source** — the subject's `# Progress` log or a linked artifact that quotes a command result / PR / tag, with the row naming where it was read (`measured(progress 2026-10-10)`, `measured(PR #240)`). A box whose own text quotes a result does **not** make itself `measured`: rating by scanning box text is exactly the string match the rating exists to separate from a real reading, and a `measured` row carrying no source is a defect rather than a pass. ⚠️ **A `none` driving cell must carry a proposal naming the missing prerequisite** — `—` against `none` is an omission, not a pass. Each run ends with a reconciliation line whose parts must sum to the box count, and emits exactly one row per box (count the boxes with `grep -c` to check). `/vault-cli:task-status --coverage` and `/vault-cli:goal-status --coverage` render the table below the anchor pair. Read-only: neither action modifies, creates, re-links or ticks anything, on the subject or on any driver.

agents/task-creator.md

@@ -17,7 +17,7 @@ You create one task file in the configured vault. You read the vault config via
 
 <constraints>
 - NEVER hardcode vault paths, tasks directories, or default assignees — read everything from `vault-cli config list --output json`
-- NEVER assume a single vault name; resolve via `--vault` argument or default vault
+- NEVER assume a single vault name; resolve via the `--vault` argument, and ask the caller when it is absent — never fall through to `default_vault`
 - NEVER overwrite an existing task file — fail with a clear error on collision
 - NEVER add auto-assignment logic; leave `assignee` empty unless the user supplies one
 - NEVER number filenames or add timestamps unless the vault convention requires it
@@ -37,15 +37,15 @@ Input form: `[task description] [--non-interactive] [--vault NAME]`.
 - `--vault NAME` → target vault override
 - Remaining tokens → task description / title
 
-Defaults: MODE = `interactive`, VAULT = configured default vault.
+Defaults: MODE = `interactive`. VAULT has no default — it comes from `--vault`, or is asked for when absent.
 
 ## 2. Resolve vault config
 
 ```bash
 vault-cli config list --output json
 ```
 
-Find the vault entry matching the requested vault name (or `default_vault` from the same config). From that entry, extract:
+Find the vault entry matching the requested vault name — the caller resolves it (`--vault`, or the vault the cwd sits in); this agent never falls back to `default_vault`. From that entry, extract:
 
 - `path` — vault root (already resolved absolute path)
 - `tasks_dir` — task folder (e.g. `40 Tasks`, `24 Tasks`); if absent, fall back to `Tasks`

commands/create-task.md

@@ -11,11 +11,19 @@ Create one task file in the vault. Which agent performs the write depends on whe
 - `--docs-only` → `ROUTE=docs` (explicit)
 - `--code` → `ROUTE=code` (explicit)
 - `--non-interactive` (deprecated alias: `--tool`) → `MODE=non_interactive` (JSON output, no prompts)
-- `--vault NAME` → target a specific vault (otherwise the default vault from `~/.vault-cli/config.yaml`)
+- `--vault NAME` → target a specific vault (otherwise resolve it per **Resolve the vault** below — never fall through to the default vault)
 - Remaining text → task description / title
 
 **`MODE` defaults to `interactive` when `--non-interactive` is absent.** The route block below switches on it, so it is always assigned — an unset `MODE` matches neither arm and leaves `ROUTE` unassigned.
 
+## Resolve the vault
+
+- `--vault NAME` given, or cwd inside a vault path → use it.
+- Neither → ask with `AskUserQuestion`, offering the vault names from `vault-cli config list`. Never infer the vault from the task's topic, and never fall through to `default_vault`: the configured default is a different vault, and landing there is a silent wrong answer.
+- **`MODE=non_interactive`** → do not ask and do not default. Fail with `❌ Pass --vault — the vault cannot be inferred headlessly.` and STOP. Mirrors the route block's arm above: a headless caller cannot answer, and a wrong guess silently takes the wrong path.
+
+Same convention as `commands/reflect.md` and `agents/graph-auditor.md` — resolve the vault, or ask; do not guess.
+
 ## Resolve the route
 
 Every path below either assigns `ROUTE` or stops; nothing falls through.