Skip to content

Ignore existing buildifier configs for crate_universe vendoring #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UebelAndre wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Ignore existing buildifier configs for crate_universe vendoring #4205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crate_universe/src/cli/vendor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,12 @@ pub struct VendorOptions {
/// the file to disk before formatting. The `path` argument is passed as
/// `--path` so buildifier can infer the file type (BUILD vs .bzl).
///
/// See <https://github.com/bazelbuild/rules_rust/issues/2972>.
/// `-config=off` disables buildifier's config discovery so the consuming
/// repo's `.buildifier.json` (and any `BUILDIFIER_CONFIG` env var) does not
/// apply lint policy to auto-generated vendored files.
fn buildifier_format(bin: &Path, content: &str, path: &Path) -> anyhow::Result<String> {
let mut child = process::Command::new(bin)
.args(["-lint=fix", "-mode=fix", "-warnings=all"])
.args(["-lint=fix", "-mode=fix", "-warnings=all", "-config=off"])
.arg(format!("--path={}", path.display()))
.stdin(process::Stdio::piped())
.stdout(process::Stdio::piped())
Expand Down
Loading