Skip to content

Include link_deps in Rust runfiles - #4204

Merged
krasimirgg merged 1 commit into
bazelbuild:mainfrom
finn-ball:agent/include-link-deps-in-runfiles
Aug 5, 2026
Merged

Include link_deps in Rust runfiles#4204
krasimirgg merged 1 commit into
bazelbuild:mainfrom
finn-ball:agent/include-link-deps-in-runfiles

Conversation

@finn-ball

Copy link
Copy Markdown
Contributor

Summary

  • merge default runfiles from link_deps into Rust target runfiles
  • include dynamic libraries supplied through link_deps alongside those from deps

Why

link_deps participates in native linking, but its runfiles and dynamic libraries were omitted when rustc_compile_action assembled runtime files. Binaries and library targets that link native dependencies through link_deps could therefore be built successfully while missing required runtime artifacts.

Impact

Rust binaries, cdylibs, and staticlibs now carry the runtime files needed by dependencies declared through link_deps.

Validation

  • bazel test //test/unit/link_deps:all
  • git diff --check

@finn-ball
finn-ball marked this pull request as ready for review August 4, 2026 17:13
@UebelAndre
UebelAndre requested a review from krasimirgg August 4, 2026 18:10

@krasimirgg krasimirgg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good!

@krasimirgg
krasimirgg added this pull request to the merge queue Aug 5, 2026
Merged via the queue into bazelbuild:main with commit 226c488 Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants