Exclusions listed in the artifact definition should be excluded in deps #1554#1555
Open
escardin wants to merge 1 commit into
Open
Exclusions listed in the artifact definition should be excluded in deps #1554#1555escardin wants to merge 1 commit into
escardin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address excluding deps as one might actually expect to happen when listing an exclusion.
I am somewhat worried that it'll break folks, but realistically you would need to allow transitives of your exclusions only as a compile time dependency? I lack imagination for how this could break someone.
Note that this doesn't remove whatever was done previously to exclude dependencies at runtime, but that code should no longer be necessary.
It's not tested against maven or gradle resolvers. I tested it with my own internal repo where I was encountering this bug where I use the coursier resolver.