Skip target generation for artifacts with null shasum#1533
Open
brocollie08 wants to merge 2 commits into
Open
Conversation
brocollie08
force-pushed
the
brocollie08-fix-aar-dep-target
branch
from
January 22, 2026 19:26
b2ee528 to
9a7d6e8
Compare
brocollie08
marked this pull request as draft
January 22, 2026 19:26
brocollie08
marked this pull request as ready for review
January 22, 2026 20:14
shs96c
requested changes
Feb 3, 2026
shs96c
left a comment
shs96c
left a comment
Collaborator
There was a problem hiding this comment.
I think that this needs a test to prevent the behaviour reverting as we continue to make changes. Could you please add one?
Author
|
@shs96c done, verified test outputs against pre-change behaviour as well |
Author
|
Could I please get a re-review on this @shs96c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address issue #1532