You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change adds first‑class truststore configuration to maven.install.
This is duplicative with/less general than the existing build --repo_env=JDK_JAVA_OPTIONS=-Djavax.net.ssl.trustStore=<path-to-cacerts> pattern but as far as I can tell there is not a good way to get that to work when the cacert file is in the repo (or built by the repo) and needs to be a relative path.
A simpler alternative to this would be to expand %workspace% variables when handling JDK_JAVA_OPTIONS but this seems more robust and specific.
Why not set the system JDK via the --server_javabase option to one that has your trust store already configured? You could also do something like startup --host_jvm_args=-Djavax.net.ssl.trustStore=/usr/lib/security/cacerts too. I'm not sure this PR is required. Have I missed something obvious?
Why not set the system JDK via the --server_javabase option to one that has your trust store already configured? You could also do something like startup --host_jvm_args=-Djavax.net.ssl.trustStore=/usr/lib/security/cacerts too. I'm not sure this PR is required. Have I missed something obvious?
We have cacerts checked into the repo; this allows referring to that file rather than assuming they'll be present on the machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds first‑class truststore configuration to maven.install.
This is duplicative with/less general than the existing
build --repo_env=JDK_JAVA_OPTIONS=-Djavax.net.ssl.trustStore=<path-to-cacerts>pattern but as far as I can tell there is not a good way to get that to work when the cacert file is in the repo (or built by the repo) and needs to be a relative path.A simpler alternative to this would be to expand
%workspace%variables when handling JDK_JAVA_OPTIONS but this seems more robust and specific.