Add support for AAR files to IndexJar#1490
Open
pettermahlen wants to merge 2 commits into
Open
Conversation
shs96c
requested changes
Dec 5, 2025
shs96c
left a comment
shs96c
left a comment
Collaborator
There was a problem hiding this comment.
This is a great change. Thank you! Would you mind just updating the test, and I'll merge it ASAP.
| InputStream jarStream, | ||
| SortedSet<String> packages, | ||
| SortedMap<String, SortedSet<String>> serviceImplementations) throws IOException { | ||
| // Don't use try-with-resources here as we don't want to close the underlying stream |
| return jarBytes.toByteArray(); | ||
| } | ||
|
|
||
| private byte[] createMinimalClassFileBytes() { |
Collaborator
There was a problem hiding this comment.
Since we know the implementation is looking at file names and not the bytes of the class, it's safe to just add the entry without the magic bytes. Could you please update the test?
Collaborator
|
@pettermahlen Could you please rebase and respond to the review comment, then I'll happily merge this |
pettermahlen
force-pushed
the
support-aar-package-extraction
branch
from
June 15, 2026 15:15
0bbd4f6 to
fb13907
Compare
Author
|
Sorry, I completely dropped the ball on this one. It's been updated, let me know if it looks OK now or if further changes are needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1489