feat: modernize dependencies and upgrade to ES6+#26
Draft
badlee wants to merge 4 commits into
Draft
Conversation
- Clone and update outdated dependencies (modem, kannel, shorty) - Convert all libraries to modern ES6+ JavaScript (classes, arrow functions, etc.) - Update package.json with recent dependency versions - Update Node.js requirement from >=0.8.0 to >=14.0.0 - Add local versions of modem, kannel, and shorty in /lib directory - Update all connector scripts to use new local dependencies - Add UPGRADE.md with migration guide - Add test scripts to verify syntax and functionality Closes: Dependencies modernization request Generated by Vibe Code Co-authored-by: badlee <badlee@users.noreply.github.com>
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
- Clone swig from paularmstrong/swig@1.4.2 - Create local version in /lib/swig with modern wrapper - Update index.js to use local swig instead of npm package - Maintain backward compatibility with existing API - Fix compatibility issues Generated by Vibe Code Co-authored-by: badlee <badlee@users.noreply.github.com>
- Fix swig wrapper to properly expose all original methods - Ensure backward compatibility with existing code - Test setFilter and setDefaults functionality Generated by Vibe Code Co-authored-by: badlee <badlee@users.noreply.github.com>
- Fix swig wrapper to expose setFilter, setDefaults, and all original methods - Include original swig-original.js for backward compatibility - Test and verify all swig methods work correctly Fixes: TypeError: swig.setFilter is not a function Generated by Vibe Code Co-authored-by: badlee <badlee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernization of Scriptbox Dependencies
Summary
Changes Made
1. Local Dependencies (in
/libdirectory)/lib/modem/: Updated fromemilsedgh/modem@1.0.3/lib/kannel/: Updated frombadlee/kannel.js@0.2.7/lib/shorty/: Updated frombadlee/shorty@0.5.52. Updated Connectors
All connector files in
/scripts/connectors/have been updated to:3. Package.json Updates
>=0.8.0→>=14.0.0Migration Guide
See UPGRADE.md for detailed migration instructions.
Testing
Breaking Changes
/lib)Benefits
✅ Modern JavaScript (ES6+)
✅ Better Performance
✅ Improved Security
✅ Better Maintainability
✅ Future-Proof
Closes #70f47316-1954-4f89-a834-6a112637dd75