fix(vault): show pending deposit progress in the sidebar

[jonybur]

Outcome

The Vaults sidebar badge shows the average progress of pending deposits. Completed deposits do not count as pending. The branch includes current main. Fresh CI is pending.

Change

• Use the same progress steps as the deposit rows.
• Update the arc when progress changes, even if the count stays the same.
• Show the rounded percentage in the tooltip and accessible name. Show it on keyboard focus.
• Keep a grey ring when progress is unknown. Hide the badge when no deposits are pending.
• Resolve the test import conflict with current main.

Safety

This changes the sidebar display. It uses existing polling results. Transaction and signing rules remain unchanged.

Verification

• All 54 focused sidebar and polling tests passed.
• Vault lint and type checks passed. Lint reports 138 warnings and no errors.
• All three PR updates merge together without conflicts. The combined vault suite passed 5,102 tests, with two skipped.
• Fresh GitHub CI must pass before merge.

Links

• Separate refund transaction change: feat(vault): keep refund transaction links after confirmation #2664.
• Shared workflow fixes: ci: waive the deliberate pull_request_target in pre-review-check #2668 and ci: fix zizmor and ci-doctor findings #2669.

The following record is from the earlier review. The checks above cover this update.

Pre-review: 0 findings · 0 fixed · 0 open (0 merge-blockers) · 0 undecided · lint/test passed

Full review covered all seven changed files. A later review checked the test import adjustment that prevents a conflict with the refund PR. Uncached affected lint and tests passed. No source file was rewritten by the checks.

[github-actions]

🔐 Commit Signature Verification

✅ All 1 commit(s) passed verification

Commit	Author	Signature	Key Type	Key Check
d4272ea22e56	Jonathan Bursztyn	✅	sk-ssh-ed25519	✅

Summary

• Commits verified: 1
• Signature check: ✅ All passed
• Key type enforcement: ✅ All sk-ssh-ed25519

---

Required key type: sk-ssh-ed25519 (FIDO2 hardware key)

Last verified: 2026-10-08 23:43 UTC

[github-actions]

Pre-review record found

A record for this branch is present at d4272ea22.

[greptile-apps]

Confidence Score: 4/5

[Medium risk] Updates pending deposit display with progress tracking.

The PR appears safe to merge, with a non-blocking accessibility improvement needed for the new progress display.

Findings

1.  Progress percentage is inaccessible ▶

Summary

The PR derives a pending-deposit count and average progress from polling results, then displays that progress in the Vaults sidebar badge.

• Progress changes update the arc without requiring a count change; completed demo deposits are excluded.
• The percentage needs an accessible presentation for keyboard and screen-reader users.

Security-guideline adherence: No SECURITY-GUARDRAILS.md was found. The changes are confined to display state and do not alter transactions, signing, or polling requests; no conflict with the repository’s security guidance was identified.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Deposit activities and polling results] --> B[Pending-deposit summary]
  B --> C[Vaults sidebar badge]
  C --> D[Count and progress arc]

Loading

_{Reviews (1) · Last reviewed commit: "fix(vault): show pending deposit progres..."}

[github-actions]

Visual regression

✅ No visual changes for d4272ea22e56 against the merge-base.