[BUGFIX] Register the blinded configuration options event listener - #36
Merged
Conversation
The listener used Symfony's AsEventListener attribute, which TYPO3 does not autoconfigure, and the extension shipped no Configuration/Services.yaml at all - so the redis password was never blinded in the backend "Configuration" module on v12, v13 or v14. Register it via the event.listener service tag instead, which works on all supported versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BlindedConfigurationOptionsHookused Symfony'sAsEventListenerattribute, which TYPO3 does not autoconfigure (it only autoconfigures its ownTYPO3\CMS\Core\Attribute\AsEventListener, and only since v13). The extension also shipped noConfiguration/Services.yaml, so nothing was registered in the container at all.Result: the redis password was never blinded in the backend "Configuration" module — on v12.4, v13.4 or v14.3.
Registering the listener with the
event.listenerservice tag works identically on all three versions. Verified against real 12.4 / 13.4 / 14.3.6 installs that the listener now reachesListenerProvider(and that the attribute version registered nothing).Also:
phpconstraint^8.0→^8.1(no supported TYPO3 runs on 8.0),typo3/cms-lowleveladded tosuggest, and the README no longer claims v8 support or the pre-v12 config filenames.