fix(deps): patch Snyk-reported npm vulnerabilities#1085
Open
digiserg wants to merge 3 commits into
Open
Conversation
Bump axios, systeminformation, uuid to patched releases and add targeted npm overrides for transitive deps (tar, dompurify, form-data, ip-address, undici, brace-expansion, js-yaml) pulled in by electron-builder, monaco-editor, eslint/jest tooling, etc. Resolves 64 of 66 vulnerable dependency paths reported at https://app.snyk.io/org/digiserg/project/fcd5a606-d93e-410f-91db-0804337aa027 (closes #1084). Two mediums remain as accepted risk, no compatible fix without breaking runtime behavior: - js-yaml 3.15.0 under front-matter (CVE-2026-53550, ReDoS) - fix only ships in js-yaml 4.x, which drops the safeLoad() API front-matter calls at runtime. - zxcvbn 4.4.2 (ReDoS) - package is unmaintained, no fixed version published. npm audit now reports 0 vulnerabilities; full test suite passes except one pre-existing, unrelated failure (missing funcs.js). Signed-off-by: Sergio Rua <sergio@axonops.com>
millerjp
approved these changes
Jul 17, 2026
@electron/rebuild override targeted undici directly, but only its nested node-gyp depends on undici — the override matched nothing and was silently dropped. node-gyp then resolved the hoisted root undici@8.7.0 (requires Node >=22.19), crashing macOS CI runners on Node 20.19.2 with "webidl.util.markAsUncloneable is not a function". Nest the override under node-gyp so it actually applies, and commit package-lock.json (previously gitignored) so CI installs are reproducible instead of re-resolving overrides fresh on every run. Signed-off-by: Sergio Rua <sergio@axonops.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
axios,systeminformation,uuidto patched versions.overridesfor transitive vulnerable deps (tar,dompurify,form-data,ip-address,undici,brace-expansion,js-yaml) pulled in by electron-builder, monaco-editor, eslint/jest tooling, etc.npm auditnow reports 0 vulnerabilities.js-yaml3.15.0 underfront-matter(CVE-2026-53550, ReDoS) — fix only ships in js-yaml 4.x, which drops thesafeLoad()APIfront-mattercalls at runtime.zxcvbn4.4.2 (ReDoS) — unmaintained, no fixed version published.Closes #1084
Test plan
npm install— native module rebuild succeeds, no resolution errorsnpm audit— 0 vulnerabilitiessnyk test --org=digiserg— down from 66 to 2 vulnerable paths (both accepted risk, documented above)npm run test:ci— 250 tests pass; 1 suite fails on missingrenderer/js/funcs.js, a pre-existing unrelated issueAssisted-by: Claude Code