fix(cql console): mark pagination counter as partial while server has more rows#1083
Open
digiserg wants to merge 2 commits into
Open
fix(cql console): mark pagination counter as partial while server has more rows#1083digiserg wants to merge 2 commits into
digiserg wants to merge 2 commits into
Conversation
… more rows Tabulator's local pagination counter only ever reflected rows already loaded into the table, so a server-paged SELECT looked "complete" after the first chunk and the page count silently grew on every "Next" click instead of showing the true state up front. Fixes #1082 Signed-off-by: Sergio Rua <sergio@axonops.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paginationCounter: 'rows'only counts rows currently loaded into the table, so a server-paged SELECT looked "complete" after the first chunk and the total silently grew with every "Next" click.paginationCounterinrenderer/js/utils/core.jsthat reads a newhasMorePendingflag on the Tabulator instance and appends+ ... (more available)while the server still has rows to fetch, switching to the exact count onceisOutputCompletedis true.events-get-connections.jsnow setstabulatorObject.hasMorePendingat table creation and on every subsequent page append, from the existingisOutputWithPaging/isOutputCompletedstate (no change to IPC shapes or fetch mechanics).Fixes #1082
Test plan
node --checkon both changed filespaginationCounterfunction confirms distinct text for pending vs. complete vs. empty statesAssisted-by: Claude Code