test(preset): raise beforeEach hook timeout for interactive create-workspace#900
Merged
Merged
Conversation
…rkspace createTestWorkspace retries workspace creation up to 3x, which can exceed vitest's default 120s hookTimeout.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 155 155
Lines 5388 5388
Branches 1263 1263
=======================================
Hits 4707 4707
Misses 359 359
Partials 322 322 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cogwirrel
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #898. The interactive
create-workspacesmoke test'sbeforeEachcallscreateTestWorkspace, which retries workspace creation up to 3× on flaky installs. Each attempt can take ~40s, so the total can exceed vitest's default 120shookTimeout, failing the setup before the test body runs.Raise the hook timeout to 10 minutes (matching the
ittimeouts used elsewhere in the e2e suite).Verification
Confirmed the interactive preset prompt works end-to-end via a PTY:
enquirer.promptrenders, accepts the typed engagementId, the generator exits 0, and the value is persisted toaws-nx-plugin.config.mtsastags: ['MyEngagementId'].Type of change