Add framework-independent Intel LKP helper utilities - #107
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new helper module autils/devel/lkp.py to drive Intel LKP microbenchmarks, providing functions to clone, install, run, and archive benchmark results. The review feedback highlights several critical improvements: validating the testbox parameter to prevent path traversal vulnerabilities, running the subsystem compilation without elevated privileges to avoid root-owned file pollution, executing lkp commands from the repository root rather than subdirectories to ensure reliability, and filtering glob results to only include valid files.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3132b7f to
c2852c8
Compare
|
Hi @Sumitupadhyay1, could you make the PR discoverable and provide some unit tests? See e.g. any previous commit regarding how new modules are added in here and what are the accompanying files in such commits. |
555354d to
2952585
Compare
@pevogam I've updated the PR with required changes. Could you please review the same. |
|
Alright, I triggered the tests and some static checks are failing. Please take a look when you can. |
Add a set of framework-independent utilities that simplify working with Intel LKP locally, including helpers to: - Clone and install lkp-tests - Split and install benchmark jobs - Run LKP microbenchmarks locally - Discover benchmark result artifacts - Archive outputs generated during benchmark runs Signed-off-by: Sumit Kumar <sumitkum@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
2952585 to
210b17e
Compare
|
@pevogam, I've taken care of failing static checks. Could you please review the same. |
pylint (docstyle/docparams extensions) flagged: - docstring-first-line-empty on the module and every function docstring - missing sphinx :type:/:rtype: fields alongside :param:/:returns: - too-many-arguments on _run (7 > 5), disabled inline - consider-using-f-string on all %-style command composition - unused-argument on unasserted mock.patch injections in the test file (renamed with a leading underscore per the project convention) - too-many-arguments on a test method with 5 @mock.patch decorators, disabled inline Verified locally with the pinned tool versions (isort==5.10.1, black==22.3.0, pylint==3.0.0) plus the unit tests, all green. Co-authored-by: Cursor <cursoragent@cursor.com>
github-project-automation
Bot
moved this from Review Requested
to Done 114
in Default project
2 participants
Add a set of framework-independent utilities that simplify working with Intel LKP locally, including helpers to:
Avocado PR: avocado-framework/avocado#6314