fix(libevm/legacy): `PrecompiledStatefulContract` gas and remaining gas handling - #114

Merged

qdm12 merged 23 commits into

mainfrom

qdm12/libevm/legacy/precompile-gas

Feb 7, 2025

Commits on Feb 4, 2025

fix(libevm/legacy): disallow remaining gas higher than input gas in `PrecompiledStatefulContract`
qdm12
committed
8d288b7
fix(libevm/legacy): allow to use all the gas in PrecompiledStatefulContract
qdm12
committed
6a8fb2e
Add context to assertions

qdm12
and
ARR4N
authored
40ea889
Remove bad copied comment from stubs_test.go

qdm12
and
ARR4N
authored
fabf9d9
Simplify check for used gas

qdm12
and
ARR4N
authored
7948b4a
Embed `vm.PrecompileEnvironment` in `stubPrecompileEnvironment`
qdm12
committed
58f2cf5
Move `stubPrecompileEnvironment` to `legacy_test.go`
qdm12
committed
5c2be65
Rename `testCase(s)` -> `test(s)`
qdm12
committed
1cf6551
Remove `input` field from tests and set it to a constant
qdm12
committed
1ba366b
Rename test field `cRet` -> `precompileRet`
qdm12
committed
da2f151
Rename test field `cRemainingGas` -> `remainingGas`
qdm12
committed
c34844f
Rename test field `cErr` -> `precompileErr`
qdm12
committed
ef76203
Move env declaration in subtest closer to where it's used
qdm12
committed
a5bcae2
Use unexported sentinel error and require.ErrorIs
qdm12
committed
5ca19fb
Check env.UseGas return value
qdm12
committed
45ee298

Commits on Feb 5, 2025

Always return `ret`
qdm12
committed
c0126a8
Reduce nesting
qdm12
committed
6de69da
Add remainingGas: 0 in test case `zero_remaining_gas`
qdm12
committed
3f1a4b5
Remove `wantRet` test case field
qdm12
committed
4910f93

Commits on Feb 6, 2025

Simplify if check using env.UseGas

qdm12
and
ARR4N
authored
58902bc
Rework gas logic since it was horrendous
qdm12
committed
b32c8c3
Rename `gas` -> `suppliedGas`
qdm12
committed
2ddb863
Fix the horrendous order of fields in zero_remaining_gas test case
qdm12
committed
0d1892b