feat(reexecution): add optional profiling support to benchmarking script - #4791
Closed
Elvis339 wants to merge 2 commits into
Closed
feat(reexecution): add optional profiling support to benchmarking script#4791Elvis339 wants to merge 2 commits into
Elvis339 wants to merge 2 commits into
Conversation
Elvis339
commented
Dec 25, 2025
| ${METRICS_SERVER_ENABLED:+--metrics-server-enabled="${METRICS_SERVER_ENABLED}"} \ | ||
| ${METRICS_SERVER_PORT:+--metrics-server-port="${METRICS_SERVER_PORT}"} \ | ||
| ${METRICS_COLLECTOR_ENABLED:+--metrics-collector-enabled="${METRICS_COLLECTOR_ENABLED}"} | ||
| # ${PROFILE:+--pprof} |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR is being closed due to no activity. Please re-open if this needs to be prioritized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This patch is part of: ava-labs/firewood#1582
Adds profiling support to the C-Chain re-execution benchmark, enabling visibility into Rust FFI performance when using Firewood. When
PROFILE=true, the binary is built with debug symbols and frame pointers, allowing profilers (pprof, perf, samply, Instruments) to resolve function names across the Go → CGO → Rust stack instead of showing opaque memory addresses.How this works
When
PROFILE=trueis set:-N) and inlining (-l) to preserve stack traces/tmp/vm_reexecutefor post-run analysisHow this was tested
1. Baseline - build without profiling flags
Output shows no Rust debug info
2. Build WITH profiling flags:
Output shows resolved Rust type/function names:
This enables profilers to display human-readable Rust call stacks instead of raw memory addresses.
If empty output run:
Need to be documented in RELEASES.md?
No