Compare against the round we held before verifying a replicated block - #485
Open
samliok wants to merge 1 commit into
Open
Compare against the round we held before verifying a replicated block#485samliok wants to merge 1 commit into
samliok wants to merge 1 commit into
Conversation
createNotarizedBlockVerificationTask decided whether to start a new round by comparing e.round against the replicated block's round, which stays true for as long as we are ahead of that block. Capture the round before processing instead, matching what createFinalizedBlockVerificationTask already does.
samliok
marked this pull request as ready for review
August 4, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createNotarizedBlockVerificationTaskdecided whether to start a new round by comparinge.roundagainstmd.Round, the round of the replicated block being verified. That asks whether we are ahead of an old block, which stays true for the whole catch up, rather than whether we just advanced.createFinalizedBlockVerificationTaskalready captures the round before processing and compares against that.Restarting the round we are already in re-runs
startRound, so a leader builds a second block for a round it has already proposed in. The test empty notarizes round 0, proposes as leader of round 1, then replicates the notarized block for round 0 and asserts round 1 is not built twice.