Remove Python 3.10 - #207
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR removes Python 3.10 support by raising the package minimum to Python 3.11, dropping the corresponding metadata and dependency workarounds, and updating CI/tooling environments. Documentation configuration now uses Python 3.11’s built-in tomllib, while documentation, lint, publishing, and pre-commit workflows run under Python 3.12. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".pre-commit-config.yaml" line_range="12" />
<code_context>
#
default_language_version:
- python: python3.10
+ python: python3.12
repos:
</code_context>
<issue_to_address>
**nitpick:** The pre-commit configuration now requires a `python3.12` executable even though the package still supports Python 3.11 (`requires-python = '>=3.11'`). Developers using the minimum supported Python version cannot install or run the configured hooks without separately installing Python 3.12.
**Triggers:** When a contributor has Python 3.11 but not Python 3.12 installed.
**Suggested fix:** Use `python3.11` for the default pre-commit language version, or document and enforce Python 3.12 as a separate tooling requirement.
```suggestion
python: python3.11
```
</issue_to_address>Sourcery assessment
Needs a human reviewer. If the new support floor is wrong, Python 3.10 users will be blocked by the published Requires-Python metadata, and the release cannot be repaired by simply reverting the repository changes. A follow-up release can restore compatibility, so the impact is bounded and recoverable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes support for Python 3.10 and adjusts code and dependencies to use new features of Python 3.11.
🤖 Generated with Claude Code