Skip to content

statx improvements #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radioactiveman merged 2 commits into from
Aug 3, 2026
Merged

statx improvements #1858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8d11cd
meson: Check for statx. Closes: #1843
radioactiveman Aug 3, 2026
ef98770
audcore: Invoke statx directly, not via syscall
radioactiveman Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config.h.meson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#mesondefine HAVE_GETTEXT
#mesondefine HAVE_SIGWAIT
#mesondefine HAVE_STATX

#mesondefine INSTALL_BINDIR
#mesondefine INSTALL_DATADIR
Expand Down
10 changes: 10 additions & 0 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,16 @@ if cxx.has_function('sigwait')
endif


if cxx.compiles('''
#include <sys/stat.h>
int main() {
struct statx stx;
return statx(0, "", 0, STATX_MTIME | STATX_BTIME, &stx);
}''', name: 'statx sample')
conf.set10('HAVE_STATX', true)
endif


if meson.version().version_compare('>= 0.59')
intl_dep = dependency('intl', required: false)
intl_found = intl_dep.found()
Expand Down
8 changes: 3 additions & 5 deletions src/libaudcore/vfs_local.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,9 +446,6 @@ bool LocalTransport::get_file_timestamps(const char * filename, int64_t * mtime,
#include <sys/stat.h>
#include <sys/types.h>

#include <sys/syscall.h>
#include <unistd.h>

bool LocalTransport::get_file_timestamps(const char * filename, int64_t * mtime,
int64_t * birthtime)
{
Expand All @@ -462,10 +459,10 @@ bool LocalTransport::get_file_timestamps(const char * filename, int64_t * mtime,
if (birthtime)
*birthtime = -1;

#ifdef HAVE_STATX
// Use statx on Linux to get creation time
struct statx stx;
if (syscall(SYS_statx, AT_FDCWD, (const char *)path, 0,
STATX_MTIME | STATX_BTIME, &stx) == 0)
if (statx(AT_FDCWD, path, 0, STATX_MTIME | STATX_BTIME, &stx) == 0)
{
if (mtime)
*mtime = stx.stx_mtime.tv_sec;
Expand All @@ -474,6 +471,7 @@ bool LocalTransport::get_file_timestamps(const char * filename, int64_t * mtime,

return true;
}
#endif

// Fallback to regular stat
struct stat st;
Expand Down
Loading