-
Notifications
You must be signed in to change notification settings - Fork 34
drivers/network: add ixgbe driver #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
terryzbai
wants to merge
4
commits into
main
Choose a base branch
from
ixgbe_driver_cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,10 @@ async def test(backend: HardwareBackend, test_config: common.TestConfig): | |
| # See https://github.com/au-ts/sddf/issues/698 for details | ||
| timeout = 30 | ||
|
|
||
| if test_config.board.startswith("vb_105"): | ||
| # This x86 machine takes around 3 mintues to boot | ||
| timeout = 200 | ||
|
|
||
|
Comment on lines
+50
to
+53
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The boot timeout is separate from the test timeout, this shouldn't be here, see https://github.com/au-ts/systems-ci/blob/f1127dfb4c47d0c5bc3512d3678b3434c3835c34/ts_ci/backends/machine_queue.py#L19 So this block should be removed |
||
| async with asyncio.timeout(timeout): | ||
| await wait_for_output(backend, b"DHCP request finished") | ||
| dhcp_client1 = await wait_for_output(backend, b"\r\n") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # | ||
| # Copyright 2026, UNSW | ||
| # | ||
| # SPDX-License-Identifier: BSD-2-Clause | ||
| # | ||
| # Include this snippet in your project Makefile to build | ||
| # the IXGBE NIC driver | ||
| # | ||
| # NOTES | ||
| # Generates eth_driver.elf (alternative unique name eth_driver_ixgbe.elf) | ||
| # Expects libsddf_util_debug.a to be in LIBS | ||
|
|
||
| ETHERNET_DRIVER_DIR := $(dir $(lastword $(MAKEFILE_LIST))) | ||
| CHECK_NETDRV_FLAGS_MD5:=.netdrv_cflags-$(shell echo -- ${CFLAGS} ${CFLAGS_network} | shasum | sed 's/ *-//') | ||
|
|
||
| ${CHECK_NETDRV_FLAGS_MD5}: | ||
| -rm -f .netdrv_cflags-* | ||
| touch $@ | ||
|
|
||
| eth_driver_ixgbe.elf: network/ixgbe/ethernet.o | ||
| $(LD) $(LDFLAGS) $< $(LIBS) -o $@ | ||
|
|
||
| network/ixgbe/ethernet.o: ${ETHERNET_DRIVER_DIR}/ethernet.c ${CHECK_NETDRV_FLAGS_MD5} | ||
| mkdir -p network/ixgbe | ||
| ${CC} -c ${CFLAGS} ${CFLAGS_network} -I ${ETHERNET_DRIVER_DIR} -o $@ $< | ||
|
|
||
|
|
||
| -include ixgbe/ethernet.d |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this works for just measuring CPU utilisation, it is kind of sus because the TSC frequency is != to the CPU frequency. You should use the PMU counter for this kind of job. Given that the ARM and RISC-V already uses the proper cycle counter.