blk/mmc: miscellaneous bug fixes - #389
Merged
Merged
Conversation
Signed-off-by: julia <git.ts@trainwit.ch>
Signed-off-by: julia <git.ts@trainwit.ch>
Signed-off-by: julia <git.ts@trainwit.ch>
* assert that the TC bit is set only if no error bits are set as it could still be high if leftover from a previous command as we don't reset after an error * special case the DMA error, as usually this is a virtualiser error to send invalid DMA addresses. * add a note about the source of "CMD/Data-inhibit set" as we experience this whenever we have an error as we don't handle them properly Signed-off-by: julia <git.ts@trainwit.ch>
midnightveil
force-pushed
the
imx-mmc-fixes
branch
from
March 31, 2025 01:11
4f7cb11 to
d77deb4
Compare
…done' This fixes random block command errors due to the inhibition flags being set, even though they often disappear afterwards, so they are random transient errors that appear. Signed-off-by: julia <git.ts@trainwit.ch>
midnightveil
force-pushed
the
imx-mmc-fixes
branch
from
March 31, 2025 02:54
d77deb4 to
25fd0e4
Compare
All card types support "Default Speed" operation. Signed-off-by: julia <git.ts@trainwit.ch>
midnightveil
force-pushed
the
imx-mmc-fixes
branch
from
March 31, 2025 02:54
25fd0e4 to
775a8af
Compare
midnightveil
marked this pull request as ready for review
March 31, 2025 02:58
11 tasks
Ivan-Velickovic
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged without squashing, see individual commit messages for more details.
Cherry picked from #180 and with an extra bugfix from @dreamliner787-9's work with virtio-blk (to be tested)