Add firewall negative integration tests for control-plane validation - #333
Open
shivamp6265 wants to merge 4 commits into
Open
Add firewall negative integration tests for control-plane validation#333shivamp6265 wants to merge 4 commits into
shivamp6265 wants to merge 4 commits into
Conversation
Add comprehensive end-to-end negative integration tests to validate the firewall's control-plane error handling... Signed-off-by: Shivam Patel <shivam@Shivams-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive end-to-end negative integration tests for the LionsOS firewall control plane. The test suite validates the HTTP API's rejection of invalid requests and ensures firewall state remains unchanged when errors occur.
Problem
The firewall's Docker runtime test suite (
autotest.sh) provides good coverage of successful operations (traffic flows, rule application, route addition/removal). However, it lacks coverage of error paths and negative cases:This leaves critical input-validation code paths untested and creates regression risk when modifying the firewall's API layer or firewall services.
Solution
Add
negative_tests.sh, a standalone shell script that:Testing
The script can be run inside the firewall test container: