Skip to content

Use design tokens for Class page spacing and type #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PriyaDVenkatesan wants to merge 3 commits into
base: design-system/font-size-tokens
Choose a base branch
from
Open

Use design tokens for Class page spacing and type #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bf4206
Use design tokens for Class page spacing and type
PriyaDVenkatesan Sep 6, 2026
568b0be
Use spacing tokens across catalog browsing
PriyaDVenkatesan Sep 10, 2026
73441d9
Use design tokens across profile and bookmarks
PriyaDVenkatesan Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/frontend/src/app/Catalog/Catalog.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
display: flex;
align-items: center;
justify-content: flex-start;
gap: 8px;
padding: 0 16px;
gap: var(--space-2);
padding: 0 var(--space-4);
}

.bookmarkButton {
Expand Down Expand Up @@ -121,7 +121,7 @@
display: inline-flex;
align-items: center;
justify-content: space-between;
gap: 12px;
gap: var(--space-3);
}

.bookmarkUnavailableItem {
Expand All @@ -132,14 +132,14 @@
font-size: var(--text-12);
color: var(--label-color);
white-space: nowrap;
margin-left: 4px;
margin-left: var(--space-1);
}

.bookmarkFolders {
display: flex;
align-items: center;
flex-wrap: nowrap;
gap: 8px;
gap: var(--space-2);
width: max-content;
}

Expand All @@ -148,7 +148,7 @@
left: 0;
top: 0;
display: flex;
gap: 8px;
gap: var(--space-2);
visibility: hidden;
pointer-events: none;
white-space: nowrap;
Expand Down
7 changes: 6 additions & 1 deletion apps/frontend/src/app/Catalog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,12 @@ export default function Catalog() {
return;
}

const gapPx = 8;
const measureRow = foldersViewportRef.current?.querySelector(
`.${styles.bookmarkMeasureRow}`
);
const gapPx = measureRow
? Number.parseFloat(window.getComputedStyle(measureRow).columnGap) || 0
: 0;
let usedWidth = 0;
const nextVisibleIds: string[] = [];

Expand Down
4 changes: 2 additions & 2 deletions apps/frontend/src/app/Profile/Account/Account.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

.infoItem label {
color: var(--text-gray);
margin-bottom: 8px;
margin-bottom: var(--space-2);
width: 250px;
max-width: 30%;
flex: 0 0 auto;
Expand All @@ -21,6 +21,6 @@

.actions {
display: flex;
gap: 16px;
gap: var(--space-4);
flex-wrap: wrap;
}
2 changes: 1 addition & 1 deletion apps/frontend/src/app/Profile/Account/DeleteAccountDialog.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
}

.icon {
margin-top: 40px;
margin-top: var(--space-7);
width: 70px;
height: 70px;
}
Expand Down
18 changes: 9 additions & 9 deletions apps/frontend/src/app/Profile/Bookmarks/CollectionCard/CollectionCard.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
display: flex;
width: 340px;
min-height: 200px;
padding: 16px;
padding: var(--space-4);
align-items: flex-start;
gap: 12px;
gap: var(--space-3);
background-color: var(--foreground-color);
border: 1px solid var(--border-color);
border-radius: 8px 8px 0 0;
Expand All @@ -68,7 +68,7 @@
.cardContent {
display: flex;
flex-direction: column;
gap: 8px;
gap: var(--space-2);
flex: 1;
}

Expand Down Expand Up @@ -100,7 +100,7 @@

.cardFooter {
display: flex;
gap: 12px;
gap: var(--space-3);
align-items: center;
}

Expand All @@ -120,7 +120,7 @@
line-height: 1;
display: flex;
align-items: center;
gap: 4px;
gap: var(--space-1);
}

.reservedIcon {
Expand All @@ -133,8 +133,8 @@
background-color: var(--foreground-color);
border-top: 1px solid var(--border-color);
padding: 20px;
padding-bottom: 40px;
margin: 0 -20px -40px -20px;
padding-bottom: var(--space-7);
margin: 0 -20px calc(-1 * var(--space-7)) -20px;
position: relative;
z-index: 2;
display: flex;
Expand All @@ -158,11 +158,11 @@
.footerContent {
display: flex;
flex-direction: column;
gap: 4px;
gap: var(--space-1);
min-width: 0;
overflow: hidden;
flex: 1;
margin-right: 12px;
margin-right: var(--space-3);
}

.collectionName {
Expand Down
22 changes: 11 additions & 11 deletions apps/frontend/src/app/Profile/Bookmarks/CollectionDetail/CollectionDetail.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
background-color: var(--foreground-color);

.header {
padding: 16px 20px;
padding: var(--space-4) 20px;
display: flex;
align-items: center;
justify-content: space-between;
gap: 12px;
gap: var(--space-3);
flex-shrink: 0;
}

Expand All @@ -26,7 +26,7 @@
align-items: center;
justify-content: center;
gap: 6px;
padding: 4px 12px;
padding: var(--space-1) var(--space-3);
height: 32px;
font-size: var(--text-14);
font-weight: var(--font-medium);
Expand Down Expand Up @@ -68,7 +68,7 @@
}

.classList {
padding: 0 20px 16px;
padding: 0 20px var(--space-4);
display: flex;
flex-direction: column;
gap: 10px;
Expand Down Expand Up @@ -96,15 +96,15 @@
align-items: center;
justify-content: center;
height: 100%;
padding: 48px;
padding: var(--space-8);
text-align: center;
color: var(--paragraph-color);

h3 {
font-size: var(--text-18);
font-weight: var(--font-semibold);
color: var(--heading-color);
margin: 0 0 8px;
margin: 0 0 var(--space-2);
}

p {
Expand Down Expand Up @@ -132,10 +132,10 @@
}

.header {
padding: 16px 20px;
padding: var(--space-4) 20px;
display: flex;
flex-direction: column;
gap: 12px;
gap: var(--space-3);
flex-shrink: 0;
}

Expand All @@ -150,7 +150,7 @@
align-items: center;
justify-content: center;
gap: 6px;
padding: 4px 12px;
padding: var(--space-1) var(--space-3);
height: 32px;
font-size: var(--text-14);
font-weight: var(--font-medium);
Expand All @@ -176,7 +176,7 @@
display: flex;
align-items: center;
justify-content: center;
padding: 4px;
padding: var(--space-1);
background: transparent;
border: none;
cursor: pointer;
Expand Down Expand Up @@ -208,7 +208,7 @@
}

.classList {
padding: 0 20px 16px;
padding: 0 20px var(--space-4);
display: flex;
flex-direction: column;
gap: 10px;
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/src/app/Profile/Bookmarks/DeleteCollectionDialog.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
}

.icon {
margin-top: 40px;
margin-top: var(--space-7);
width: 70px;
height: 70px;
color: var(--red-500);
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/src/app/Profile/Notifications/Notifications.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
font-size: var(--text-16);
color: var(--paragraph-color);
line-height: 1.6;
margin: 8px 0 0 0;
margin: var(--space-2) 0 0 0;
max-width: 80%;
}

Expand Down
28 changes: 14 additions & 14 deletions apps/frontend/src/app/Profile/Profile.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
}

.sidebar {
padding: 48px 40px;
padding: var(--space-8) var(--space-7);
border-right: 1px solid var(--border-color);
display: flex;
flex-direction: column;
gap: 24px;
gap: var(--space-5);
flex-shrink: 0;

@media (max-width: 991px) {
Expand All @@ -29,14 +29,14 @@
.navGroup {
display: flex;
flex-direction: column;
gap: 16px;
gap: var(--space-4);
}

.navItem {
padding: 0;
display: flex;
align-items: center;
gap: 8px;
gap: var(--space-2);
cursor: pointer;
color: var(--paragraph-color);

Expand All @@ -48,7 +48,7 @@

span {
font-weight: var(--font-medium);
font-size: 16px;
font-size: var(--font-sizes-3);
line-height: 20px;
letter-spacing: -0.1px;
white-space: nowrap;
Expand All @@ -71,12 +71,12 @@
}

.contentInner {
padding: 48px;
padding: var(--space-8);
width: 100%;
max-width: 1500px;
display: flex;
flex-direction: column;
gap: 48px;
gap: var(--space-8);
height: fit-content;
}

Expand All @@ -89,17 +89,17 @@
.pageContent {
display: flex;
flex-direction: column;
gap: 48px;
gap: var(--space-8);
}

.section {
display: flex;
flex-direction: column;
gap: 24px;
gap: var(--space-5);
}

.sectionTitle {
font-size: 24px;
font-size: var(--font-sizes-6);
font-weight: var(--font-semibold);
margin: 0;
}
Expand All @@ -115,7 +115,7 @@
display: flex;
align-items: center;
justify-content: space-between;
margin-bottom: 4px;
margin-bottom: var(--space-1);
}

.ratingsSection {
Expand All @@ -129,11 +129,11 @@
display: flex;
align-items: center;
justify-content: space-between;
margin-bottom: 4px;
margin-bottom: var(--space-1);
}

.addRatingButton {
padding: 4px 12px;
padding: var(--space-1) var(--space-3);
height: 32px;
font-size: var(--text-14);
font-weight: var(--font-normal);
Expand All @@ -150,7 +150,7 @@
}

.newCollectionButton {
padding: 4px 12px;
padding: var(--space-1) var(--space-3);
height: 32px;
font-size: var(--text-14);
font-weight: var(--font-normal);
Expand Down
8 changes: 4 additions & 4 deletions apps/frontend/src/app/Profile/Ratings/RatingCard/RatingCard.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
.metricRow {
display: flex;
align-items: center;
padding: 24px 0;
padding: var(--space-5) 0;
gap: 20px;

&:not(:last-child) {
Expand All @@ -44,20 +44,20 @@
align-items: center;
justify-content: space-between;
width: 100%;
padding: 16px;
padding: var(--space-4);
border-bottom: 1px solid var(--border-color);
box-sizing: border-box;
}

.classInfo {
display: flex;
flex-direction: column;
gap: 4px;
gap: var(--space-1);
}

.actions {
display: flex;
gap: 8px;
gap: var(--space-2);
}

.className {
Expand Down
Loading
Loading