MAST: Resolve objects more performantly#3615
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3615 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 227 227
Lines 21072 21077 +5
=======================================
+ Hits 15417 15422 +5
Misses 5655 5655 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bsipocz
approved these changes
Jun 17, 2026
bsipocz
left a comment
bsipocz
left a comment
Member
There was a problem hiding this comment.
This all looks good, thanks!
Temporarily commenting out NED sounds totally fine, but maybe you want to open up an issue as a reminder so it's more likely to get a revisit in the future than a TODO left in the test file itself.
| utils, | ||
| ) | ||
|
|
||
| from ...exceptions import ( |
Member
There was a problem hiding this comment.
A bit of bikeshedding, but I wonder if you could fine tune your linter's setting for astroquery and not do these reformats for shorter lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to resolve named objects with our MAST resolver service more performantly.