avoid generating uuidv7 by default, once postgres v18 is detected#793
Merged
Conversation
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Contributor
Author
|
oh wow! that was fast <3 ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi! I hope I won't do harm by trying to address the remaining bit of #672.
unfortunately, I'm not "happy" of the solution I'm submitting, here. but it's the best I've got so far. would LOVE some feedback.
here I'm introducing
optsonAshPostgres.MigrationGenerator.AshFunctions, butoptslitters the whole file - there's an area of effect larger than I've anticipated.I iterated with other designs, e.g. using
String.replace/3, avoiding littering the file - but I just didn't like it tbh.I'd be happy to rework this if you have a better idea on how to tackle it.
Contributor checklist
Leave anything that you believe does not apply unchecked.