Actually have the fix for #448.#782
Closed
torazar wants to merge 0 commit into
Closed
Conversation
Contributor
Author
|
Apparently I didn't know some things about git. Didn't realize I had to manually add new files I made. |
Contributor
|
Looking at the extent of this fix, it seems overbearing. Modifying all read actions on a resource, and threading through a timeout like this when in reality it seems like this issue should have a simple fix somewhere. Where is the timeout getting dropped from the query? I think in this case the first thing we need is a diagnosis of exactly where the timeout issue is going wrong. |
Contributor
Author
|
Right. Turns out there are two places with problems. First, Ash never passes query.timeout to the data layer, Second, Ash only passes the Ecto query to run_query, not the Ash query. |
Contributor
|
So it would seem there is a minimal fix possible in that case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.