Skip to content

Actually have the fix for #448.#782

Closed
torazar wants to merge 0 commit into
ash-project:mainfrom
torazar:main
Closed

Actually have the fix for #448.#782
torazar wants to merge 0 commit into
ash-project:mainfrom
torazar:main

Conversation

@torazar

@torazar torazar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@torazar

torazar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Apparently I didn't know some things about git. Didn't realize I had to manually add new files I made.

@zachdaniel

Copy link
Copy Markdown
Contributor

Looking at the extent of this fix, it seems overbearing. Modifying all read actions on a resource, and threading through a timeout like this when in reality it seems like this issue should have a simple fix somewhere. Where is the timeout getting dropped from the query?

I think in this case the first thing we need is a diagnosis of exactly where the timeout issue is going wrong.

@torazar

torazar commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Right. Turns out there are two places with problems. First, Ash never passes query.timeout to the data layer, Second, Ash only passes the Ecto query to run_query, not the Ash query.

@zachdaniel

Copy link
Copy Markdown
Contributor

So it would seem there is a minimal fix possible in that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants