Address review comments on #51263 (backport to CMSSW_17_0_X)#4
Merged
artlbv merged 1 commit intoJul 7, 2026
Conversation
…amespace tau typedefs, drop empty dtor, dedupe model name string - Move tauinput_t/tauresult_t typedefs into the L1TauEmu namespace to avoid clashing with other hls4ml model headers, updating all call sites - Replace the empty TauNNIdHW destructor with = default - Store the "NNPuppiTauModel_v1" model name in a single constant in the cppunit test and in the python config instead of repeating the literal Co-authored-by: artlbv <4972492+artlbv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the same review-comment fixes made in #3 to the CMSSW_17_0_X backport branch used by cms-sw/cmssw#51294 (backport of cms-sw#51263).
Addresses the review comments left on cms-sw/cmssw#51263 review by @quinnanm:
TauNNIdHW.h: move thetauinput_t/tauresult_ttypedefs into theL1TauEmunamespace to avoid clashing with other hls4ml model headers, updating all call sites accordingly.TauNNIdHW.cc: replace the empty~TauNNIdHW() {}definition with~TauNNIdHW() = default;in the header.testNNPuppiTauModel.cppunit.cc: store the repeated"NNPuppiTauModel_v1"string in a singlekModelNameconstant.L1NNTauProducer_cff.py: store the repeated"NNPuppiTauModel_v1"string in a singlennPuppiTauModelNamevariable and reuse it for both producer configs.Base is set to
nnpuppitau-externals-migration_CMSSW_17_0_Xso this can be merged into it directly.Generated by Claude Code