Repository navigation
fix: PAA mipmaps of 2^24 bytes - #48
Merged
Merged
Conversation
The mipmap size has 24 bits, an uncompressed 4096x4096 DXT5 mipmap (2^24 bytes) stores 0. Its data was read as the next mipmap header. Uncompressed DXT1 and DXT5 blocks always fill the mipmap, so their size follows from the dimensions when it matches the stored size mod 2^24.
TheWillard
force-pushed
the
fix/paa-mipmap-size-wrap
branch
from
November 6, 2026 21:04
cd6daca to
6d36ea7
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mipmap size in a PAA has 24 bits. An uncompressed 4096x4096 DXT5 mipmap is 2^24 bytes and stores 0, so its data was read as the next mipmap header. Found in two terrain textures of the
@rhspklmod (rhspkl_art.pbo:blud_elvebunn_nopx.paa,blud_elvebunn_malingsvei_nohq.paa), one of which panicked before #47.Uncompressed DXT1 and DXT5 blocks always fill the mipmap, so their size now follows from the dimensions when it matches the stored size mod 2^24. Only mipmaps of 2^24 bytes or more change.
Based on #47 for its DXT block size.