Repository navigation
fix: resolve SSL field type, RPC failure check, generated package name, and context support - #5
Merged
Merged
Conversation
The SSL field previously stored the protocol prefix ('http://' or
'https://') instead of a boolean indicating whether SSL is enabled.
Changed to a bool field named UseSSL for clarity and correctness.
checkRPCFailure previously returned an error if error_message existed even when result was 'success'. Fixed with proper type-switch comparison instead of fragile fmt.Sprintf.
Generated wrappers previously declared 'package metasploit' inside pkg/msfrpc/generated/, causing import collisions with the typed SDK at pkg/metasploit/. Fixed generator to output 'package generated'. Added context variants for all generated methods, consistent with the rest of the API. Each method now has a non-context wrapper delegating to a Context variant.
Replace hardcoded credentials with MSF_HOST/MSF_PORT/MSF_SSL/MSF_USER/ MSF_PASS environment variables, with sensible localhost defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.