-
Notifications
You must be signed in to change notification settings - Fork 21
Add HTTPVersion type and HTTPVersionInfo server capability
#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ehaydenr
wants to merge
1
commit into
apple:main
Choose a base branch
from
ehaydenr:httpversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+98
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
Sources/HTTPAPIs/Server/HTTPServerCapability+HTTPVersionInfo.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift HTTP API Proposal open source project | ||
| // | ||
| // Copyright (c) 2026 Apple Inc. and the Swift HTTP API Proposal project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| public import NetworkTypes | ||
|
|
||
| @available(anyAppleOS 26.0, *) | ||
| extension HTTPServerCapability { | ||
| /// A capability for request contexts that expose the HTTP version used for the | ||
| /// connection a request arrived on. | ||
| public protocol HTTPVersionInfo: RequestContext, ~Copyable, ~Escapable { | ||
| /// The HTTP version used for this request | ||
| var httpVersion: HTTPVersion { get } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift HTTP API Proposal open source project | ||
| // | ||
| // Copyright (c) 2026 Apple Inc. and the Swift HTTP API Proposal project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| /// Representation of an HTTP version. | ||
| public struct HTTPVersion: Sendable, Hashable { | ||
| private enum Representation: UInt8, Sendable, Hashable { | ||
| case http1_0 | ||
| case http1_1 | ||
| case http2 | ||
| case http3 | ||
| } | ||
|
|
||
| private let representation: Representation | ||
|
|
||
| private init(_ representation: Representation) { | ||
| self.representation = representation | ||
| } | ||
|
|
||
| /// HTTP/1.0, as defined in RFC 1945. | ||
| public static var http1_0: HTTPVersion { | ||
| .init(.http1_0) | ||
| } | ||
|
|
||
| /// HTTP/1.1, as defined in RFC 9112. | ||
| public static var http1_1: HTTPVersion { | ||
| .init(.http1_1) | ||
| } | ||
|
|
||
| /// HTTP/2, as defined in RFC 9113. | ||
| public static var http2: HTTPVersion { | ||
| .init(.http2) | ||
| } | ||
|
|
||
| /// HTTP/3, as defined in RFC 9114. | ||
| public static var http3: HTTPVersion { | ||
| .init(.http3) | ||
| } | ||
| } | ||
|
|
||
| extension HTTPVersion: CustomStringConvertible { | ||
| public var description: String { | ||
| switch self.representation { | ||
| case .http1_0: "HTTP/1.0" | ||
| case .http1_1: "HTTP/1.1" | ||
| case .http2: "HTTP/2" | ||
| case .http3: "HTTP/3" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the
Infosuffix?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, will drop it once we resolve Guoye's HTTPVersion type question